Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CYPRESS_NO_COMMAND_LOG=1 leaves faulty empty space #21271

Closed
agalias opened this issue Apr 29, 2022 · 3 comments · Fixed by #22641
Closed

CYPRESS_NO_COMMAND_LOG=1 leaves faulty empty space #21271

agalias opened this issue Apr 29, 2022 · 3 comments · Fixed by #22641
Labels
pkg/reporter This is due to an issue in the packages/reporter directory type: bug type: regression A bug that didn't appear until a specific Cy version release

Comments

@agalias
Copy link

agalias commented Apr 29, 2022

Current behavior

Hello, currently when running CYPRESS_NO_COMMAND_LOG=1 npm run cy:open and opening any test - there is some space left where Test Runner Command Log should be. Probably because of reporter

Screenshot 2022-04-28 at 17 33 43

Probably empty space is left there because <div class="reporter-wrap" style="left: 0px;"></div> is not deleted. If to delete it and resize the Test Runner window - empty space will disappear.

vid.mov

Desired behavior

There is no space left where Test Runner Command Log should be when using CYPRESS_NO_COMMAND_LOG=1 environment variable:
Screenshot 2022-04-28 at 17 40 19

Test code to reproduce

Should be reproducible anywhere, I tested it on the fresh 9.6.0 Cypress project with getting started examples.

Cypress Version

8.7.0, 9.6.0

@davidmunechika davidmunechika added the pkg/reporter This is due to an issue in the packages/reporter directory label May 2, 2022
@cypress-bot cypress-bot bot added the stage: investigating Someone from Cypress is looking into this label May 2, 2022
@davidmunechika
Copy link
Contributor

davidmunechika commented May 3, 2022

Thanks for opening an issue. I was able to reproduce on 9.6.0 and 8.0.0. It looks like a regression occurred sometime between v7.0.0 (verified it works) and v8.0.0 (verified it does not work).

@mjhenkes mjhenkes added type: bug type: regression A bug that didn't appear until a specific Cy version release labels May 3, 2022
@cypress-bot cypress-bot bot added stage: routed to team brandon and removed stage: investigating Someone from Cypress is looking into this labels May 3, 2022
@rockhold
Copy link

rockhold commented Jun 6, 2022

I tested this out in v10.0.2 and realized we don't yet have support for this environment variable in v10+. Here is a related issue for implementing that support: #21721

We should ensure that the spacing issue called out here is taken care of as part of that work.

@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: backlog labels Jun 30, 2022
@cypress-bot cypress-bot bot added stage: review and removed stage: needs review The PR code is done & tested, needs review labels Jul 11, 2022
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 19, 2022

Released in 10.3.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.3.1, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jul 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg/reporter This is due to an issue in the packages/reporter directory type: bug type: regression A bug that didn't appear until a specific Cy version release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants