Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write cy.origin integration tests for Azure Active Directory #21476

Closed
mjhenkes opened this issue May 13, 2022 · 5 comments · Fixed by #22568
Closed

Write cy.origin integration tests for Azure Active Directory #21476

mjhenkes opened this issue May 13, 2022 · 5 comments · Fixed by #22568
Assignees
@mschile @AtofStryker
Milestone
experimentalSessi...

Comments

@mjhenkes
Copy link
Member

mjhenkes commented May 13, 2022 •
edited
Loading

What would you like?

Each of these modifyObstructiveCode tasks should include two tasks

  1. Implement this authentication provider in the real world app.
  2. Test logging in via the authentication provider in the real world app.
  • This may involve modifying modifyObstructiveCode or other tasks.

Why is this needed?

Workflows using Azure Active Directory for authentication currently cannot succeed due to frame busting.

Other

Related issues:
@mjhenkes mjhenkes changed the title ModifyObstructiveCode for Azure Active Directory Write cy.origin integration tests for Azure Active Directory May 17, 2022
@mjhenkes mjhenkes changed the title Write cy.origin integration tests for Azure Active Directory Write cy.origin integration tests for Azure Active Directory May 17, 2022
@mschile mschile mentioned this issue Jun 6, 2022
Closed
@mjhenkes mjhenkes assigned mschile and unassigned AtofStryker Jun 21, 2022
@pedrocarloto
Copy link

Hello!
Thanks for working on this. Do you know if this will also solve the authentication problem with Google Auth?
Thank you.

@mschile
Copy link
Contributor

mschile commented Jun 23, 2022

Hi @pedrocarloto, we have #21474 logged to solve Google Auth.

@akamud
Copy link

akamud commented Jun 28, 2022

Hi, do we have any guide on how to write the cy.origin for a new SSO?

@AtofStryker AtofStryker self-assigned this Jun 28, 2022
@AtofStryker AtofStryker mentioned this issue Jun 28, 2022
Merged
4 tasks
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: internal labels Jun 28, 2022
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Jul 22, 2022
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 22, 2022

The code for this is done in cypress-io/cypress#22568, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 2, 2022

Released in 10.4.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.4.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mschile mschile

@AtofStryker AtofStryker

Labels
None yet
Projects
None yet
Milestone
experimentalSessionAndOrigin GA
Development

Successfully merging a pull request may close this issue.

feat: add experimentalModifyObstructiveThirdPartyCode flag for regex rewriter cypress-io/cypress
6 participants
@akamud @chrisbreiding @pedrocarloto @mjhenkes @mschile @AtofStryker