Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CT Stack Traces #21720

Closed
sync-by-unito bot opened this issue May 30, 2022 · 7 comments · Fixed by #23916
Closed

CT Stack Traces #21720

sync-by-unito bot opened this issue May 30, 2022 · 7 comments · Fixed by #23916
Assignees
Labels
CT Issue related to component testing

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented May 30, 2022

Summary

In E2E we show a stack trace if there is an error in the test. It is (5) here:

!image-2022-02-09-20-16-55-107.png|thumbnail!

We want the same thing for CT. Right now, webpack dev server does not supply the correct source map - in fact, it doesn't have one at all. Also, even if it did, the seam between the dev-server and CT runner is not set up for stack traces.

For CT we go here https://github.com/cypress-io/cypress/blob/10.0-release/packages/driver/src/cypress/script_utils.ts#L49 as opposed to E2E which goes on and calls this https://github.com/cypress-io/cypress/blob/10.0-release/packages/driver/src/cypress/script_utils.ts#L36 which gets the source map.

Acceptance Criteria

  • Should return the source map from webpack dev server
  • Should extract and display it for component testing

Resources

Brian telling Lachlan about source maps for an hour or so:

Meeting Recording:
https://cypress-io.zoom.us/rec/share/hiYJyb9yjp7W7UKPbow0gG3gum1Az7kXA7Yq8XtQGU0AcNUEpdSTo43JL-Zs59uJ.-2OgUXVt2mTAcgZp
Access Passcode: message @lmiller1990

Open Pull Requests

Any PRs needed for review

┆Issue is synchronized with this Jira Task by Unito
┆Attachments: image-2022-02-09-20-16-55-107.png
┆author: Lachlan Miller
┆epic: CT Post Unification Release
┆friendlyId: UNIFY-1070
┆priority: Low
┆sprint: Unification Release Backlog
┆taskType: Task

@sync-by-unito sync-by-unito bot added CT Issue related to component testing epic:ct-post-unification-release labels May 30, 2022
@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 30, 2022

➤ Brian Mann commented:

I paired with lachlan on this last night and explained everything to him, so he should be fully enabled on this

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 30, 2022

➤ Lachlan Miller commented:

PR will be here eventually https://github.com/cypress-io/cypress/pull/20138/files ( https://github.com/cypress-io/cypress/pull/20138/files|smart-link )

I have some OOO coming, and expect to have to pick up some other things while working on this, so opening this PR early just to give visibility to my work.

@baus
Copy link

baus commented Aug 24, 2022

@ZachJW34
Copy link
Contributor

Do source maps for the vite-dev-server work? Or is it just webpack-dev-server?

@lmiller1990
Copy link
Contributor

Not sure, but I'm guessing source maps are a pre-requisite for correct and accurate stack traces.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 26, 2022

The code for this is done in cypress-io/cypress#23916, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 27, 2022

Released in 10.9.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.9.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Sep 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CT Issue related to component testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants