Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for NO_COMMAND_LOG env variable not implemented #21721

Closed
sync-by-unito bot opened this issue May 30, 2022 · 7 comments · Fixed by #22641
Closed

Support for NO_COMMAND_LOG env variable not implemented #21721

sync-by-unito bot opened this issue May 30, 2022 · 7 comments · Fixed by #22641
Assignees

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented May 30, 2022

The NO_COMMAND_LOG env variable can be used in Cypress 9.x to disable rendering of the command log; see the troubleshooting guide for user-facing info.

Screen Shot 2022-02-09 at 12 08 17 PM

We should support similar functionality to this in 10.0.

┆Issue is synchronized with this Jira Bug by Unito
┆Attachments: Screen Shot 2022-02-09 at 12.08.17 PM.png
┆author: Tyler Biethman
┆epic: 9.x Parity
┆friendlyId: UNIFY-1077
┆priority: High
┆sprint: Unification Release Backlog
┆taskType: Bug

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 30, 2022

➤ Zach Williams commented:

NO_COMMAND_LOG is passed via the cypress config, we could pull this value and conditionally render the reporter in packages/reporter/src/main.tsx

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 30, 2022

➤ Tyler Biethman commented:

Noting that we have a skipped spec that can be enabled with the completion of this work:

it.skip('supports disabling command log reporter with env var NO_COMMAND_LOG', () => {
loadSpec({
fileName: 'disabled-command-log.runner.cy.js',
passCount: 0,
failCount: 0,
})
cy.get('.reporter').should('not.exist')
})
})

@rockhold
Copy link

rockhold commented Jun 6, 2022

When adding this support, we need to ensure the command log doesn't take up space in the UI as reported as a previous regression in #21271

@pmcochrane
Copy link

Can we please get this feature back in v10? Enabling it drastically reduces the overall time whilst running the tests headless so it could even be prioritized higher.

I can live without the detail in the test screenshots/video if the tests runs twice as fast.
I dont really want to revert to an earlier version as I have just gone through the pain of migrating the build process to v10

@vergjor
Copy link

vergjor commented Jun 29, 2022

honestly the lack of this feature is preventing me to migrate to version 10 of cypress, since it has a major influence on our test execution, I really hope this is implemented as soon as possible

@marktnoonan marktnoonan self-assigned this Jun 30, 2022
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: backlog labels Jun 30, 2022
@marktnoonan
Copy link
Contributor

@pmcochrane @vergjor I ran across the skipped test for this yesterday which led me to this issue, I've opened a PR and it should make it in to a release pretty soon.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 19, 2022

Released in 10.3.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.3.1, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jul 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants