Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shows "1 Matches" in for SpecPattern. Use existing pluralization logic. #21728

Closed
sync-by-unito bot opened this issue May 30, 2022 · 4 comments · Fixed by #22773
Closed

Shows "1 Matches" in for SpecPattern. Use existing pluralization logic. #21728

sync-by-unito bot opened this issue May 30, 2022 · 4 comments · Fixed by #22773
Assignees
Labels

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented May 30, 2022

Summary

We have pluralization logic elsewhere in the application. Remove anything with "math", because i18n handles this all for us.

Steps to reproduce:

  1. Go to project settings with 1 spec
  2. See “Spec Pattern” section

Observe: Pluralization logic is wrong.

en-US.json

{ "someKey": "No Matches | { matches } Match | { matches } Matches" }

Code

t('someKey', { count: matches, { matches })

┆Issue is synchronized with this Jira Bug by Unito
┆Attachments: Screen Shot 2022-02-10 at 8.00.52 PM.png
┆author: Jess Sachs
┆epic: Minor Bugs
┆friendlyId: UNIFY-1111
┆priority: Low
┆sprint: Unification Release Backlog
┆taskType: Bug

@kshastri
Copy link
Contributor

kshastri commented Jun 2, 2022

I can take this up in case anyone else is not working on this.

@kshastri
Copy link
Contributor

kshastri commented Jun 3, 2022

@jennifer-shehane - I picked this issue. However, could not locate the occurrence of the bug. Is it possible to get more details on the issue?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 19, 2022

The code for this is done in cypress-io/cypress#22773, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 19, 2022

Released in 10.3.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.3.1, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jul 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants