Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rows in Specs List should be clickable all the way across #21783

Closed
sync-by-unito bot opened this issue May 30, 2022 · 5 comments · Fixed by #22105
Closed

Rows in Specs List should be clickable all the way across #21783

sync-by-unito bot opened this issue May 30, 2022 · 5 comments · Fixed by #22105
Assignees

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented May 30, 2022

Current Behavior

Only parts of the the rows in the specs list are clickable:

whole-row.click.events.on.main.specs.list.mp4

Expected Behavior

Clicking on the whole row should produce the same result as clicking on a folder name or a spec name.

This row has changed, it now contains interactive content and needs a distinct hover state: see this slack thread for context.

For the hover state, this figma prototype shows the icon on the left being highlighted with color, and the spec title text darkening by a few shades when any part of the row is hovered.

Since some parts of the row are now clickable, only clicking on non-interactive parts should trigger the navigation.

┆Issue is synchronized with this Jira Bug by Unito
┆Attachments: Screen Shot 2022-05-20 at 9.46.17 AM.png
┆author: Mark Noonan
┆epic: UI/UX Improvements
┆friendlyId: UNIFY-1434
┆priority: Medium
┆sprint: Fast Follows 1
┆taskType: Bug

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 30, 2022

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 30, 2022

➤ Brian Mann commented:

Does this need design?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 30, 2022

➤ Mark Noonan commented:

Brian Mann it only needs design if this figma design hover state is not accurate - otherwise I was just going to go with that. Highlight the icon and darken the spec name. For consistency we should do that with the folders row as well. This would match the hover states in the Inline Specs List, which makes sense to me.

What I see now in the 10.0 Specs List is a partial implementation of the App-Cloud integration design: the Last Updated column from that prototype has replaced the Git Status column, but the Latest Runs and Average Duration columns are not there yet. In the slack thread I link in the ticket, Ryan is fine with that update as part of 10.0 release. But yeah probably worth confirming that what I’ve outlined above is acceptable for the hover state.

Screen Shot 2022-05-20 at 9 46 17 AM

@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review stage: internal and removed stage: open stage: needs review The PR code is done & tested, needs review labels Jun 3, 2022
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 8, 2022

The code for this is done in cypress-io/cypress#22105, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 10, 2022

Released in 10.1.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.1.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jun 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants