Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing 'Try again' button with config error appears to do nothing #21785

Closed
sync-by-unito bot opened this issue May 30, 2022 · 5 comments · Fixed by #22514
Closed

Pressing 'Try again' button with config error appears to do nothing #21785

sync-by-unito bot opened this issue May 30, 2022 · 5 comments · Fixed by #22514
Assignees

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented May 30, 2022

It’s clear that “Try again” does work. But there’s no indication that it’s “trying” and that if it fails again, it has done so after trying. It just appears to do nothing.

Slack thread:

https://cypressio.slack.com/archives/C02MW5QBD4K/p1649088983846219

┆Issue is synchronized with this Jira Bug by Unito
┆Attachments: Screen Shot 2022-04-26 at 4.31.08 PM.png
┆author: Chris Breiding
┆epic: UI/UX Improvements
┆friendlyId: UNIFY-1445
┆priority: Medium
┆sprint: Fast Follows 1
┆taskType: Bug

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 30, 2022

➤ Mark Noonan commented:

Suggestion: we briefly put a disabled state on this button after clicking, and swap out the circle-arrow for the pending spinner, to show that input was received and we did indeed try again.

Putting a 1 on this assuming the solution will be this or something like it:

Screen Shot 2022-04-26 at 4 31 08 PM

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 30, 2022

➤ Jennifer Shehane commented:

Good to move forward with Mark’s suggestion. This is the most basic implementation we could do.

@astone123
Copy link
Contributor

I was looking into this today when I noticed another bug with re-trying configurations. I created a bug for that, and I think that it doesn't make sense to make this change until that bug is addressed

#22389

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 1, 2022

The code for this is done in cypress-io/cypress#22514, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 19, 2022

Released in 10.3.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.3.1, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jul 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants