Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

projectId looks strange in a project not set up to record to Dashboard #21806

Closed
sync-by-unito bot opened this issue May 30, 2022 · 5 comments · Fixed by #23823
Closed

projectId looks strange in a project not set up to record to Dashboard #21806

sync-by-unito bot opened this issue May 30, 2022 · 5 comments · Fixed by #23823
Labels
good first issue Good for newcomers

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented May 30, 2022

image-20220404-191921

Steps:

  1. Open a project not set up to record to the dashboard (no projectId)
  2. Open “Dashboard Settings”
  3. Observe that there is a section that says “Project ID projectId The project ID configured for this project inside of Cypress Dashboard”

Acceptance Criteria: There should be a state when no projectId is set that explains there is no projectId, or the project ID section should not be visible at all.

┆Issue is synchronized with this Jira Task by Unito
┆Attachments: image-20220404-191921.png | image-20220404-192354.png
┆author: Zach Bloomquist
┆epic: UI/UX Improvements
┆friendlyId: UNIFY-1499
┆priority: Low
┆sprint: Backlog
┆taskType: Task

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 30, 2022

➤ Zach Bloomquist commented:

image-20220404-192354

For reference, this is how it looks once set up.

@raph941
Copy link

raph941 commented Aug 23, 2022

Hello @flotwig,
Could you please help to confirm the preferred resolution strategy for this issue.
i.e between the two options listed above.

  • There should be a state when no projectId is set that explains there is no projectId
    • For this option, how should the proposed state look like (ui/wording) for it.
  • The project ID section should not be visible at all

@flotwig
Copy link
Contributor

flotwig commented Aug 26, 2022

Hi @raph941, I would think the best approach would be #2, just not display these 2 lines at all, only the button:

image

@raph941
Copy link

raph941 commented Sep 14, 2022

Thanks @flotwig PR #23823 is ready for review, kindly take a look.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 25, 2022

Released in 10.11.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.11.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Oct 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants