Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove punctuation from 'Learn more.' button in UI #21807

Closed
sync-by-unito bot opened this issue May 30, 2022 · 3 comments · Fixed by #21935
Closed

Remove punctuation from 'Learn more.' button in UI #21807

sync-by-unito bot opened this issue May 30, 2022 · 3 comments · Fixed by #21935
Labels
type: bug

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented May 30, 2022 •
edited by jennifer-shehane
Loading

I don’t think we need punctuation in buttons

Screen Shot 2022-04-04 at 3 14 25 PM

┆Issue is synchronized with this Jira Bug by Unito
┆Attachments: Screen Shot 2022-04-04 at 3.14.25 PM.png
┆author: Paul Jaffre
┆epic: UI/UX Improvements
┆friendlyId: UNIFY-1500
┆priority: Lowest
┆sprint: Backlog
┆taskType: Bug
@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 30, 2022

➤ Paul Jaffre commented:

Note: there are other buttons that have punctuation https://www.loom.com/i/f2a7c47193524feaa5adc486dfaee21f ( https://www.loom.com/i/f2a7c47193524feaa5adc486dfaee21f|smart-link )

Some punctuation (“!” / “?”) is more appropriate over the period here. We should just be consistent, perhaps Ryan Wilke can chime in on the proper/universal voice for UI text.

@sainthkh sainthkh mentioned this issue May 31, 2022
Merged
1 task
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review stage: contributor pr in progress and removed stage: needs review The PR code is done & tested, needs review labels May 31, 2022
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 8, 2022

The code for this is done in cypress-io/cypress#21935, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 10, 2022

Released in 10.1.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.1.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jun 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Remove period in "learn more." button sainthkh/cypress
0 participants