Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Create Blank Spec' dialog should be a form. Hitting "Enter" should behave like a form submit button. #21815

Closed
sync-by-unito bot opened this issue May 30, 2022 · 2 comments · Fixed by #23163
Assignees
Labels
good first issue Good for newcomers

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented May 30, 2022

Currently, the “Create New Blank Spec” modal is functionally a form, but does not behave like one. The “Create Spec” button does nothing when Enter is pressed. This is a form, but doesn’t behave like one. For a11y reasons, we should be treating this flow as a form submission.
On mac: create new empty spec > name file (or not) > {press enter}

Screen Shot 2022-04-04 at 5 06 18 PM

┆Issue is synchronized with this Jira Task by Unito
┆Attachments: Screen Shot 2022-04-04 at 5.06.18 PM.png
┆author: Jess Sachs
┆epic: UI/UX Improvements
┆friendlyId: UNIFY-1516
┆priority: Lowest
┆sprint: Backlog
┆taskType: Task

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 10, 2022

The code for this is done in cypress-io/cypress#23163, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

joshwooding pushed a commit to joshwooding/cypress that referenced this issue Aug 10, 2022
…spec (cypress-io#23163)

* In the 'Create Blank Spec' dialog the input is now in a form,so  hitting "Enter" should submits the form which creates the blank spec.
Fixes cypress-io#21815

* cypress-io#21815 Handle invalid spec pattern

* improve test (cypress-io#23205)

Co-authored-by: Zachary Williams <ZachJW34@gmail.com>
Co-authored-by: Lachlan Miller <lachlan.miller.1990@outlook.com>
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 15, 2022

Released in 10.5.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.5.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants