Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save filter term in Specs List #21837

Closed
sync-by-unito bot opened this issue May 30, 2022 · 7 comments · Fixed by #22755
Closed

Save filter term in Specs List #21837

sync-by-unito bot opened this issue May 30, 2022 · 7 comments · Fixed by #22755
Assignees

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented May 30, 2022

Summary

In 9.x when you filter Specs, the filter term is preserved for the next time you open that project, so that you can easily pick up where you left off. Blue pointed this out here on slack and the thread is a bit unclear. It seems like we do want it but it didn’t get a ticket. Plus Cesar did have a comment that

{quote}I remember in the requirements or review we were told to turn off the history. We had it at first{quote}

So it seems like this was built, then removed, but that most of us would like it.

Acceptance Criteria

  • Specs List filter should prefill based on what you had in there last time you ran Cypress for the project
  • Inline Specs List should also be able to set and read this value

Resources

The components involved are the InlineSpecsList packages/app/src/specs/InlineSpecList.vue and the SpecList packages/app/src/specs/SpecsList.vue. In the slack thread Lachlan mentions

{quote}Should be trivial to add this to the projectPrefences stuff we have set up{quote}

A good reference for something that does this from a user action at the moment is setActiveBrowser here. It is called indirectly by the GraphQL Mutation launchpadSetBrowser defined here. The mutation is poorly named as now we call if from more places than just the launchpad 😬 - the OpenBrowserList component from launchpad, and the VerticalBrowserList component that is used a couple of places in the App. The other half of this would be making sure that insertProjectPreferencesToCache is used and that the AllowedState type is updated to allow the new string.

┆Issue is synchronized with this Jira Task by Unito
┆author: Mark Noonan
┆epic: 9.x Parity
┆friendlyId: UNIFY-1588
┆priority: High
┆sprint: Backlog
┆taskType: Task

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 30, 2022

➤ Jennifer Shehane commented:

We do want this, we have had several internal devs complain that this is missing. This is great to keep as state per project so you don’t have to search every single time you open the same project when you’re working on a large feature branch.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 30, 2022

➤ Zach Bloomquist commented:

Really surprised that this is marked as Priority: Low, given the internal demand and that this marks a regression from 9.x. Can this be re-prioritized Jennifer Shehane ?

@marktnoonan
Copy link
Contributor

This issue (#22203) reports a use case for maintaining the search term in memory, both when returning to the main specs list and when using the inline list. I think that the way to address this is to fully define the outcome of this issue, since we know that we want it for 9.x parity.

The required "clear" button (at least, on the main specs list search) is in progress as a good first issue, which means we are probably ready to do this when it's prioritized.

@marktnoonan
Copy link
Contributor

I've updated this with requirements based on comments from Brian and other feedback that's come in from users, and removed the "Refinement TODOs". I'm going to suggest we add this to the next sprint for the CT team. I spiked into it a little yesterday morning and while there is a tiny bit of complexity around preserving this for the project when it is opened/closed, it's not bad.

@estefafdez
Copy link

Yes please, this was functionality we used a lot to run the next spec without the need of typing again the name or the folder or the spec.

@marktnoonan
Copy link
Contributor

@estefafdez can I confirm you are aware of the inline specs list that is part of the Spec Runner page in v10? It might provide a workaround until this gets merged. It will preserve the search term and folder state when it's opened or closed.

Screen Shot 2022-06-20 at 9 34 03 PM

Screen Shot 2022-06-20 at 9 35 21 PM

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 15, 2022

Released in 10.5.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.5.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants