Skip to content

Punctuation inconsistent + nitpick UI for e2e vs ct comparison popup #21852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sync-by-unito bot opened this issue May 30, 2022 · 2 comments · Fixed by #22680
Closed

Punctuation inconsistent + nitpick UI for e2e vs ct comparison popup #21852

sync-by-unito bot opened this issue May 30, 2022 · 2 comments · Fixed by #22680
Labels
good first issue Good for newcomers

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented May 30, 2022 •
edited by jennifer-shehane
Loading

Summary

key-diffs

Acceptance Criteria

  • Should have consistent punctuation
  • Should have shorter code comments so horizontal scrolling isn’t necessary.

Resources

https://cypressio.slack.com/archives/C039JEKF9M0/p1650558865655239

┆Issue is synchronized with this Jira Task by Unito
┆Attachments: key-diffs.png
┆author: Rachel Ruderman
┆epic: UI/UX Improvements
┆friendlyId: UNIFY-1627
┆priority: Lowest
┆sprint: Backlog
┆taskType: Task
@jennifer-shehane jennifer-shehane added the good first issue Good for newcomers label May 31, 2022
@rubinda rubinda mentioned this issue Jul 5, 2022
Merged
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review stage: contributor pr in progress and removed stage: needs review The PR code is done & tested, needs review labels Jul 5, 2022
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 13, 2022

The code for this is done in cypress-io/cypress#22680, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@chrisbreiding
Copy link
Contributor

Released in 10.3.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.3.1, please open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Remove punctuation, shorten example comment rubinda/cypress
2 participants
@chrisbreiding @jennifer-shehane