Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up inconsistencies in UI between sentence case and title case #21854

Closed
sync-by-unito bot opened this issue May 30, 2022 · 2 comments · Fixed by #23681
Closed

Clean up inconsistencies in UI between sentence case and title case #21854

sync-by-unito bot opened this issue May 30, 2022 · 2 comments · Fixed by #23681

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented May 30, 2022 •
edited by jennifer-shehane
Loading

Summary

casing

Acceptance Criteria

  • Should be using sentence case for all UI at Cypress. This was part of our design principles a long time ago. Ask [~accountid:557058:d9379c59-60d6-4907-990f-597be52b8fa6] for reference if needed.

Resources

https://cypressio.slack.com/archives/C02MYBT9Y5S/p1650559130964789

┆Issue is synchronized with this Jira Task by Unito
┆Attachments: casing.png
┆author: Rachel Ruderman
┆epic: UI/UX Improvements
┆friendlyId: UNIFY-1635
┆priority: Lowest
┆sprint: Backlog
┆taskType: Task
@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 30, 2022

➤ Brandon Rockhold commented:

For any places in the UI where we can make the casing changes but where there is no existing Percy snapshot to update, we should evaluate whether it is appropriate to create new snapshots to fill those snapshot gaps we have today. This PR ( #21460 ), for example, did not require any changes to Percy snapshots upon changing the casing.

@gitstart gitstart mentioned this issue Sep 5, 2022
Merged
4 tasks
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 25, 2022

Released in 10.11.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.11.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Oct 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: clean up inconsistencies in UI between sentence case and title case gitstart/cypress
0 participants