Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy button shouldn't be in scrollable content, should be statically in bottom righthand corner #21862

Closed
sync-by-unito bot opened this issue May 30, 2022 · 3 comments · Fixed by #22510
Assignees
Labels
good first issue Good for newcomers

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented May 30, 2022

Summary

The Copy button is in the scrollable content area for each code block, which means it's hidden until scrolled into view. I would expect it to be always visible (but only in cases where it was valuable to have Copy functionality)

image (44)

https://cypressio.slack.com/archives/C02MYBT9Y5S/p1650562472173859

┆Issue is synchronized with this Jira Task by Unito
┆Attachments: image (44).png
┆author: Ben Alman
┆epic: UI/UX Improvements
┆friendlyId: UNIFY-1649
┆priority: Low
┆sprint: Backlog
┆taskType: Task

@marktnoonan
Copy link
Contributor

When this is picked up, let's first make the 2 changes here and close that issue: #21860

After that, this overflow situation might not happen, since it is contextual, and in other contexts we might already handle it. If we can still trigger the bug somewhere, we can fix it at the place.

@marktnoonan
Copy link
Contributor

This was completed by #22510

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 19, 2022

Released in 10.3.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.3.1, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jul 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants