Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking breadcrumbs for project doesn't do anything on some pages in the Launchpad #21911

Closed
sync-by-unito bot opened this issue May 30, 2022 · 5 comments · Fixed by #22648
Closed

Clicking breadcrumbs for project doesn't do anything on some pages in the Launchpad #21911

sync-by-unito bot opened this issue May 30, 2022 · 5 comments · Fixed by #22648
Assignees

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented May 30, 2022

Summary

my-app-ts on the left corner is clickable, but when it’s clicked it does nothing - the continue in the bottom on the page needs to be clicked to change the view otherwise it stays there..

image (1)

image (2)

https://cypressio.slack.com/archives/C02MYBT9Y5S/p1652977080252969

Acceptance Criteria

  • Make the breadcrumb unclickable in areas where it will do nothing?

┆Issue is synchronized with this Jira Task by Unito
┆Attachments: 10.0 - can go back during project setup and get in confusing state.mp4 | image (1).png | image (2).png
┆author: Alejandro Estrada
┆epic: UI/UX Improvements
┆friendlyId: UNIFY-1776
┆priority: Medium
┆sprint: Fast Follows 1
┆taskType: Task

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 30, 2022

➤ Jennifer Shehane commented:

I can "Go Back" during project setup and end up in a confusing state. Users probably shouldn't be able to click "projectName" after scaffolding since we want them to scroll down and "Continue".

Via Zach Bloomquist

10.0.-.can._go.back_.during.project.setup.and.get.in.confusing.state.mp4

https://cypressio.slack.com/archives/C02MW5QBD4K/p1652983395819639 ( https://cypressio.slack.com/archives/C02MW5QBD4K/p1652983395819639|smart-card )

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 30, 2022

➤ Jennifer Shehane commented:

Via Muaz Othman

When setting up testing for the first time, there is a step in both E2E and Component Testing where the only option is to “Continue” at the bottom of the page, and clicking the project name in the breadcrumb at the top does nothing.
https://www.loom.com/share/a3bb6dba7e854e72a7f4ffc266c698c3 ( https://www.loom.com/share/a3bb6dba7e854e72a7f4ffc266c698c3|smart-link )
https://www.loom.com/share/62589b47ab3f47eaa9a5d9cae443a9e3 ( https://www.loom.com/share/62589b47ab3f47eaa9a5d9cae443a9e3|smart-link )

https://cypressio.slack.com/archives/C02MYBT9Y5S/p1652983520005119 ( https://cypressio.slack.com/archives/C02MYBT9Y5S/p1652983520005119|smart-card )

@marktnoonan
Copy link
Contributor

marktnoonan commented Jun 6, 2022

This project-name link in the Launchpad header currently only ever takes the user back to the "Testing Type" picker. The only valid place to from which to go back to that part of the launchpad is when you are at the "Choose a Browser" stage. The link should never be clickable if:

  • the user is setting up a testing type -> these are one-way setups that require you to stay in the testing type you've picked until complete
  • there is an error being displayed -> no point "unsetting" the testing type here, you will end up at the picker after you clear the error, but you won't know that until the error clears, so the link will at first appear to do nothing.

Since the "Choose a Browser" page already has a prominent link to "switch testing types", my suggestion is that for now, we just don't make the project name in the header a link.

In the original designs, the "switch testing type" link was not a part of the "Choose a Browser" screen, but now that it exist, the header link is made redundant by the more obvious button that does the same thing.

@ryanjwilke what do you think of this? My thinking is that making sure the link is only active when "safe" to go back to the testing type picker doesn't help users that much, but creates edge cases that have to be guarded against.

@ryanjwilke
Copy link
Contributor

@marktnoonan Sorry I'm just seeing this notification now. I've been cleaning out my inbox because Apple Mail is pretty terrible. The breadcrumb links should be linked in the top left only when there is something that it can actually be linked to. There are some new designs in the works which should simplify this a little more for navigation globally. Also, moving everything back into the Launchpad should theoretically fix this particular problem as well I believe.

@marktnoonan
Copy link
Contributor

This one's no longer an issue - it looks like you and I discussed it at the time and changed the behavior in #22648

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants