Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For E2E scaffolded blank specs, scaffold a spec that passes instead of fails. #21921

Closed
sync-by-unito bot opened this issue May 30, 2022 · 4 comments · Fixed by #22070
Closed

For E2E scaffolded blank specs, scaffold a spec that passes instead of fails. #21921

sync-by-unito bot opened this issue May 30, 2022 · 4 comments · Fixed by #22070
Assignees

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented May 30, 2022

Summary

When creating a new blank e2e test, should we maybe use a cy.log instead of a cy.visit? If they don't have a site setup prior to generating the test we just create a new failing test.

Screen.Recording.2022-05-19.at.2.04.54.PM.mov

https://cypressio.slack.com/archives/C02MYBT9Y5S/p1652987237554559

Acceptance Criteria

  • Maybe the content of the test should be
cy.log('Write Cypress tests')
// cy.visit('website-url-here')

// or, expect(true).to.be.true

┆Issue is synchronized with this Jira Task by Unito
┆Attachments: Screen Recording 2022-05-19 at 2.04.54 PM.mov
┆author: Matt Henkes
┆epic: UI/UX Improvements
┆friendlyId: UNIFY-1796
┆priority: Medium
┆sprint: Fast Follows 1
┆taskType: Task

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 30, 2022

➤ Blue Frauenglass commented:

I'm not completely sure I agree. Scaffolding a spec which shows "how cypress is usually used" seems more valuable to me than getting something immediately green.

The existing default spec has always been nice when I set up new projects - it gives me an immediate next step, “get cy.visit working” (by some combination changing the URL, starting my server, or setting a baseUrl).

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 30, 2022

➤ Brian Mann commented:

We probably should be visiting the kitchensink like we do when we scaffold all the example specs for you. That or no cy commands at all…

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 6, 2022

The code for this is done in cypress-io/cypress#22070, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot removed the stage: open label Jun 6, 2022
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 6, 2022

Released in 10.0.3.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.0.3, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jun 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants