Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process_profiler is broken in 10.0.0 #22022

Closed
flotwig opened this issue Jun 2, 2022 · 2 comments · Fixed by #22363
Closed

process_profiler is broken in 10.0.0 #22022

flotwig opened this issue Jun 2, 2022 · 2 comments · Fixed by #22363
Assignees
Labels
type: bug v10.0.0 🐛 Issue present since 10.0.0

Comments

@flotwig
Copy link
Contributor

flotwig commented Jun 2, 2022

Current behavior

process_profiler is broken: https://docs.cypress.io/guides/references/troubleshooting#Log-memory-and-CPU-usage

  1. The namespace was changed to verbose in the 10.0 merge, which broke the documented behavior.
  2. "plugins" group detection is broken - it was probably not updated for 10.0. There actually seems to be a lot of the old plugin code still in here that should be removed.
  3. procs.params can be undefined which causes it to fail
  4. No full e2e tests

Desired behavior

  1. Change the _printGroupedProcesses namespace back to debug from debugVerbose
  2. Fix plugin PID detection so the grouping works.
  3. Check proc.params for truthiness before using .includes
  4. Add better e2e tests

Test code to reproduce

--

Cypress Version

10.0.0

Other

No response

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 22, 2022

The code for this is done in cypress-io/cypress#22363, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 28, 2022

Released in 10.3.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.3.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug v10.0.0 🐛 Issue present since 10.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants