Skip to content

Remove autocomplete from inputs in Cypress UI #22102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ZachJW34 opened this issue Jun 3, 2022 · 4 comments · Fixed by #22456
Closed

Remove autocomplete from inputs in Cypress UI #22102

ZachJW34 opened this issue Jun 3, 2022 · 4 comments · Fixed by #22456
Labels
CT Issue related to component testing type: enhancement Requested enhancement of existing feature v10.0.0 🐛 Issue present since 10.0.0

Comments

@ZachJW34
Copy link
Contributor

ZachJW34 commented Jun 3, 2022

Current behavior

There are a few inputs inside the Cypress App with some not-so-great looking autocompletes. They look like tootlips and aren't aligned properly.

Screen Shot 2022-06-03 at 3 55 45 PM
Screen Shot 2022-06-03 at 3 59 07 PM

Desired behavior

We should disable autocomplete for our inputs.

Test code to reproduce

Open up Cypress App and type in the spec search filter. Click on a spec and navigate back, the autocomplete should show in the spec search input.

Cypress Version

10.0.2

Other

No response

@ZachJW34 ZachJW34 added epic:ui-ux-improvements v10.0.0 🐛 Issue present since 10.0.0 labels Jun 3, 2022
@mjhenkes mjhenkes added the type: enhancement Requested enhancement of existing feature label Jun 6, 2022
@mjhenkes mjhenkes added CT Issue related to component testing and removed stage: fire watch labels Jun 6, 2022
@estefafdez
Copy link

+1 to this issue, sometimes you can't type properly the name of the specs because of that.

@marktnoonan
Copy link
Contributor

@viniciuspietscher if you want to grab another small issue, this one requires adding the attribute autocomplete="off" to the input elements in the following files:

  • packages/app/src/components/FileMatchInput.vue
  • packages/app/src/runner/selector-playground/SelectorPlayground.vue
  • packages/frontend-shared/src/components/Input.vue

And updating the component tests for each one to validate that the attribute is present.

@cypress-bot cypress-bot bot added the stage: needs review The PR code is done & tested, needs review label Jun 22, 2022
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Jun 30, 2022
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 30, 2022

The code for this is done in cypress-io/cypress#22456, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 19, 2022

Released in 10.3.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.3.1, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jul 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CT Issue related to component testing type: enhancement Requested enhancement of existing feature v10.0.0 🐛 Issue present since 10.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants