Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modifyObstructiveCode getting error in cypress v10 for cypress.config.ts #22146

Closed
jenishgandhi7 opened this issue Jun 6, 2022 · 5 comments · Fixed by #23694
Closed

modifyObstructiveCode getting error in cypress v10 for cypress.config.ts #22146

jenishgandhi7 opened this issue Jun 6, 2022 · 5 comments · Fixed by #23694
Labels
good first issue Good for newcomers Reproducible Can be reproduced topic: typescript type: bug v10.0.0 🐛 Issue present since 10.0.0

Comments

@jenishgandhi7
Copy link

jenishgandhi7 commented Jun 6, 2022

Current behavior

modifyObstructiveCode getting error in cypress v10 for cypress.config.ts

Desired behavior

No response

Test code to reproduce

image

Cypress Version

10.0.2

Other

No response

@lmiller1990 lmiller1990 added topic: typescript v10.0.0 🐛 Issue present since 10.0.0 labels Jun 7, 2022
@lmiller1990
Copy link
Contributor

Thanks for the report. Now we've got strongly typed config via cypress.config.ts, we are starting to see some of our types are not perfect.

@cypress-bot cypress-bot bot added the stage: investigating Someone from Cypress is looking into this label Jun 7, 2022
@AtofStryker AtofStryker added the Reproducible Can be reproduced label Jun 8, 2022
@AtofStryker
Copy link
Contributor

Hey @jenishgandhi7. It looks like the type is indeed missing from cypress.d.ts and is a bug. The type likely needs to be added to ResolvedConfigOptions, but omitted from ComponentConfigOptions and UserConfigOptions.

Once fixed, the modifyObstructiveCode option should only be available under e2e in the config.

I think this value has always been missing in our types, but I think it is now noticeable now that we have cypress.config.ts as an option.

@cypress-bot cypress-bot bot added stage: routed to e2e-core and removed stage: investigating Someone from Cypress is looking into this labels Jun 8, 2022
@mjhenkes mjhenkes added stage: investigating Someone from Cypress is looking into this E2E-core and removed stage: routed to e2e-core labels Jun 8, 2022
@AtofStryker AtofStryker removed their assignment Jun 13, 2022
@mschile mschile added triage and removed triage labels Aug 18, 2022
@cypress-bot cypress-bot bot added stage: backlog and removed stage: investigating Someone from Cypress is looking into this stage: backlog labels Aug 22, 2022
@mihaela-ioica
Copy link

I get this error too for modifyObstructiveCode: false in the cypress.config.ts file on Cypress version 10.6.0

@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: to do labels Sep 7, 2022
@AtofStryker
Copy link
Contributor

@mihaela-ioica This should now be fixed in #23694 and should be in the next release which is next week. If for some reason it is not, please let us know!

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 13, 2022

Released in 10.8.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.8.0, please open a new issue.

@cypress-bot cypress-bot bot removed the stage: needs review The PR code is done & tested, needs review label Sep 13, 2022
@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Sep 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers Reproducible Can be reproduced topic: typescript type: bug v10.0.0 🐛 Issue present since 10.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants