Proxy-Authorization header created with basic with a small "b"

[Buluc-Celik-Ozbul]

Current behavior

When I set up a proxy with username and password, the Proxy-Authorization header is created with basic type but it says "basic" with small "b" and this fails with some proxies

Desired behavior

The Proxy-Authorization header should have been created with "Basic" keyword with a capital "B"

Test code to reproduce

The script used:
"set HTTP_PROXY=http://username:password@proxy_ip:8080 & cypress open --browser chrome --config-file cypress.json"

The test function:
And("I try cypress request", () => {

var url = `https://www.somewebsite.com/`;

const options = {
    method: 'GET',
    url: url
};

cy.request(options).then((response) => {
    console.log('cypress request: ', response);
});

});

Cypress Version

9.7.0

Other

No response

[lmiller1990]

My understanding is Basic is correct, and basic is not. Seems like a bug we should fix - I've marked it as such, and someone will look into it.

I'm not sure where the code that sets this is, but if you'd like to try make a PR, that'd be great, too - you can probably just do a full text, case sensitive search of the code base to find out where it's set.

[Buluc-Celik-Ozbul]

Hi, thanks for the quick response. I have prepared a commit, but I got this:
remote: Permission to cypress-io/cypress.git denied to Buluc-Celik-Ozbul.

I guess I need permission to push. Alternatively, here are the only needed changes if you could do it instead:

/packages/network/lib/agent.ts
line 41:
- connectReq.push(Proxy-Authorization: basic ${Buffer.from(proxy.auth).toString('base64')})
+ connectReq.push(Proxy-Authorization: Basic ${Buffer.from(proxy.auth).toString('base64')})

/packages/network/test/unit/agent_spec.ts
line 611:
- 'Proxy-Authorization: basic YmF6OnF1dXg=',
+ 'Proxy-Authorization: Basic YmF6OnF1dXg=',

[mjhenkes]

@Buluc-Celik-Ozbul, you will need to fork the repo to contribute.

https://github.com/cypress-io/cypress/blob/develop/CONTRIBUTING.md

[cypress-bot]

Released in 10.3.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.3.1, please open a new issue.