Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to blockHosts config value should trigger restart #22634

Closed
tbiethman opened this issue Jun 30, 2022 · 5 comments · Fixed by #24257
Closed

Changes to blockHosts config value should trigger restart #22634

tbiethman opened this issue Jun 30, 2022 · 5 comments · Fixed by #24257
Labels

Comments

@tbiethman
Copy link
Contributor

Current behavior

The blockHosts config value does not trigger a server restart on change, which results in those values not getting picked up in the current Cypress instance. This is inconsistent with our controls around other values and will lead to confusion.

Desired behavior

Cypress restarts when the blockHosts config value changes so that the new value is used.

Test code to reproduce

  • Open a project with specs that make requests to external hosts
  • Run the specs and see those requests made in the reporter logs
  • Add blockHosts config values that would block those requests, notice that cypress does not restart
  • Run tests again, notice that the requests are still not blocked
  • Quit and relaunch Cypress
  • Run spec again, notice previous requests are now blocked and absent from the reporter log

Cypress Version

10.3.0

Other

Relevant config: https://github.com/cypress-io/cypress/blob/develop/packages/config/src/options.ts#L140-L143

@konnster99
Copy link

hi can i try this issue?

@emilyrohrbough
Copy link
Member

@konnster99 That would be great!

@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: fire watch labels Oct 14, 2022
@meisster
Copy link
Contributor

Since there was almost a month of inactivity, I tried to take care of the issue in the linked PR.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 14, 2022

The code for this is done in cypress-io/cypress#24257, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Oct 14, 2022
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 25, 2022

Released in 10.11.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.11.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Oct 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants