Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add banner treatments for incomplete connection states #22637

Closed
pstakoun opened this issue Jun 30, 2022 · 3 comments · Fixed by #22810
Closed

Add banner treatments for incomplete connection states #22637

pstakoun opened this issue Jun 30, 2022 · 3 comments · Fixed by #22810
Assignees
@mike-plummer

Comments

@pstakoun
Copy link
Contributor

pstakoun commented Jun 30, 2022 •
edited by mike-plummer
Loading

What is needed?

When project is in a "incomplete connection" state for ACI data we want to display a banner at the top of the Specs Explorer to make it more obvious how to remedy the project configuration so that ACI data can resolve. This includes the following:

  • Bad project ID (not found)
    Screen Shot 2022-07-13 at 1 35 58 PM

  • Unauthorized (request access)
    Screen Shot 2022-07-13 at 1 36 16 PM

We display a similar style of banner when offline, should be able to extend/reuse this component

Why is it needed?

Other info
@pstakoun
Copy link
Contributor Author

Designs can be tracked and referenced here: https://app.clickup.com/t/18033298/DESIGN-1187

@mike-plummer mike-plummer mentioned this issue Jul 15, 2022
Merged
2 tasks
@mike-plummer mike-plummer self-assigned this Jul 19, 2022
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 26, 2022

The code for this is done in cypress-io/cypress#22810, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 2, 2022

Released in 10.4.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.4.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mike-plummer mike-plummer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add banners for incomplete project connection states cypress-io/cypress
2 participants
@pstakoun @mike-plummer