Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Flaky Badge & Tooltip into Specs List #22657

Closed
mike-plummer opened this issue Jul 1, 2022 · 3 comments
Closed

Integrate Flaky Badge & Tooltip into Specs List #22657

mike-plummer opened this issue Jul 1, 2022 · 3 comments
Assignees

Comments

@mike-plummer
Copy link
Contributor

mike-plummer commented Jul 1, 2022

https://www.figma.com/file/DgeFrhaX8N9ufrzvxzLnPg/app-cloud-int%3A-flake-tooltip?node-id=2456%3A49923

Display Flaky Badge & Tooltip as inline row data within Specs Explorer list

Work Items

  1. Combine Flaky Badge and Flaky Badge tooltip content into a component that can be rendered as an actionable popper
  2. Update Spec List props & data flow to determine whether to render flaky indicator (see Integrate new Flaky API data via GQL #22656)
  3. Display flaky badge when spec row is indicated as flaky
  4. Ensure offline state is handled (no errors when cloud data not available)

Acceptance Criteria

  1. Validate accessibility and keyboard navigation
  2. Validate contrast, spacing, and responsiveness at smaller viewport widths
  3. Flaky badge is only displayed for flaky spec rows
  4. Tooltip displays on hover of badge and displays appropriate content
  5. Badge & tooltip update accordingly when cloud recordings update (including hiding/showing badge dynamically as flaky status changes)
  6. Badge and tooltip are both navigable - take user to flaky portion of dashboard
  7. Component and E2E tests are updated to validate behavior for non-flaky and flaky spec combinations
@baus
Copy link

baus commented Jul 11, 2022

@mike-plummer mike-plummer self-assigned this Jul 19, 2022
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review stage: review and removed stage: in progress stage: needs review The PR code is done & tested, needs review labels Aug 9, 2022
@mike-plummer
Copy link
Contributor Author

Resolved by #23049

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 15, 2022

Released in 10.5.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.5.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants