Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard Integration banner state for "no projectId"/"connect your project" state #22798

Closed
pstakoun opened this issue Jul 14, 2022 · 7 comments
Assignees

Comments

@pstakoun
Copy link
Contributor

pstakoun commented Jul 14, 2022

This is an info banner as per the designs in Figma.

The connect project CTA should send the user to the "connect project modal".
If the banner is dismissed, it should never be shown again.

The conditions for this banner to be visible are:

  • The user is not logged in
  • The user has at least 1 organization
  • The current project is not connected (i.e. no projectId)
  • The user has been using Cypress for at least 4 days (at least 96 hours since first open)
    • The automatic docs prompts should not pop up within 24 hours of the banners, the same way the docs do not pop up within 24 hours of each other (the banners get priority, so the docs prompts only pop up if no banners have been shown for 24 hours) - we will likely have to make this change in shouldShowPrompt in HeaderBarContent.vue
  • There are no error, warning, or higher priority info banners present
  • The banner has never been dismissed by the user

The copy for this banner should be the "A" variant described in this doc.

Please reference this sheet for info about all relevant states.

@pstakoun pstakoun changed the title Add banner treatment for "no projectId"/"connect your project" state Dashboard Integration banner state for "no projectId"/"connect your project" state Jul 26, 2022
@abelb
Copy link

abelb commented Jul 28, 2022

@baus
Copy link
Collaborator

baus commented Aug 1, 2022

@abelb
Copy link

abelb commented Aug 1, 2022

Figma Link

image

@marktnoonan
Copy link
Contributor

This one is hard to estimate by itself, it really forms part of a larger system of managing what we show when:

There are no error, warning, or higher priority info banners present

Is there an epic for the general work around creating this prioritized queue of errors/warnings/info message (I might just not have seen this yet). So it's not totally clear what work needs to be included under this ticket, or whether it would extend work done in other tickets.

@pstakoun
Copy link
Contributor Author

pstakoun commented Aug 2, 2022

@mike-plummer @warrensplayer do you guys want to create a separate "banner controller" issue of some sort? Will defer to you guys as to how to handle that. cc @marktnoonan

@mike-plummer
Copy link
Contributor

Completed in #23256

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 30, 2022

Released in 10.7.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.7.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants