Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Dashboard Integration column hover interactions #22932

Closed
pstakoun opened this issue Jul 26, 2022 · 15 comments · Fixed by #23584
Closed

Improved Dashboard Integration column hover interactions #22932

pstakoun opened this issue Jul 26, 2022 · 15 comments · Fixed by #23584
Assignees

Comments

@pstakoun
Copy link
Contributor

pstakoun commented Jul 26, 2022

Improve experience of hovering over and interacting with the Latest runs and Average duration columns.

Figma Prototype

AC:

  • Replace empty run dots with dashes when user is not logged in or does not have a valid project connected
  • User hovering over dashes, will see one of the following on hover, depending on the state:
    • Connect (for log in flow)
    • Connect project (for connect project flow, if no valid project)
    • Request access (for request access flow, if no access)
  • When offline, no hover behavior, just show the --
  • No connection to smart prompts, but the CTAs should map to those in the header tooltips
  • Include UTM params for login

Here are the states in Figma

ClickUp

@baus
Copy link

baus commented Aug 1, 2022

@abelb
Copy link

abelb commented Aug 1, 2022

Design: WIP

Figma Link

@lmiller1990
Copy link
Contributor

lmiller1990 commented Aug 2, 2022

@abelb what are we supposed to be looking at specifically? I just see

image

It's not clear on what is required for delivery of this ticket. Maybe we could annotate the screenshot, some red arrows, something like that.

@pstakoun can you clarify the improvements a bit?

@marktnoonan
Copy link
Contributor

I'd agree, there is not currently a task here that can be estimated.

@pstakoun
Copy link
Contributor Author

pstakoun commented Aug 2, 2022

Added a few notes but need to sync with @abelb on the final iteration of this

@pstakoun
Copy link
Contributor Author

pstakoun commented Aug 2, 2022

We are moving this to a future sprint. Sorry about the incompleteness here.

@pstakoun pstakoun changed the title Improved Dashboard Integration column hover and tooltip interactions Improved Dashboard Integration column hover interactions Aug 3, 2022
@abelb
Copy link

abelb commented Aug 3, 2022

Updated Design!! Away with that weird big hover target.

Figma Prototype (Tooltips on column headers are broken in proto fyi fixing)

Updates

  1. Replace empty run dots with dashes
  2. When not logged in, user hovers over dashes and depending on state, will see one of the following on hover:

Here are the states in Figma

@pstakoun
Copy link
Contributor Author

pstakoun commented Aug 3, 2022

@abelb what would 'Record a run' do here? Should that be the 'Request access' CTA to match tooltip logic?

@abelb
Copy link

abelb commented Aug 3, 2022

@pstakoun good point. let me update

@pstakoun
Copy link
Contributor Author

pstakoun commented Aug 8, 2022

@abelb can you add the finalized designs here based on our latest iterations?

@abelb
Copy link

abelb commented Aug 8, 2022

image

@pstakoun
Copy link
Contributor Author

pstakoun commented Aug 9, 2022

@abelb should this have an ease-in/out? Prototype currently doesn't and I think it did before. I honestly don't have an opinion re: whether or not to do this, just want to clarify.

@abelb
Copy link

abelb commented Aug 10, 2022

I added some to the prototype - yes some ease in / out is good.

Figma Prototype

@marktnoonan
Copy link
Contributor

@warrensplayer this had been in blocked, was it intentionally moved to Open? I don't recall exactly what we were waiting on that made it blocked.

If it's unblocked from what we saw as blocking on Tuesday, we might want to flag that there's a dependency here on #23379 which will attempt to consolidate the Login + "cloud connect" components in a way that will support this ticket - since this ticket would then be implementing a new stylistic variation of that new component and putting it into the specs list.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 30, 2022

Released in 10.7.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.7.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants