Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard Integration Smart Record Run Notification #22935

Closed
pstakoun opened this issue Jul 26, 2022 · 13 comments
Closed

Dashboard Integration Smart Record Run Notification #22935

pstakoun opened this issue Jul 26, 2022 · 13 comments
Assignees

Comments

@pstakoun
Copy link
Contributor

pstakoun commented Jul 26, 2022

This is an info banner as per the designs in Figma.

The banner should show the record command.
If the banner is dismissed, it should never be shown again.

The conditions for this banner to be visible are:

  • The user is logged in
  • The user has at least 1 organization
  • The current project is connected (i.e. has valid projectId)
  • The user has been using Cypress for at least 4 days (at least 96 hours since first open)
    • The automatic docs prompts should not pop up within 24 hours of the banners, the same way the docs do not pop up within 24 hours of each other (the banners get priority, so the docs prompts only pop up if no banners have been shown for 24 hours) - we will likely have to make this change in shouldShowPrompt in HeaderBarContent.vue
  • There are no error, warning, or higher priority info banners present
  • The banner has never been dismissed by the user

The copy for this banner should be the "A" variant described in this doc.

Please reference this sheet for info about all relevant states.

@mike-plummer
Copy link
Contributor

@pstakoun Other "smart notification" issues don't reference the "only show if it's been 2 days" behavior - is that intended to be applied to those as well? Going to need a bit more info about how this applies - is the 2-day restriction based on showing a notification that "comes before" this one in the setup workflow, or does it also apply to itself (only show this prompt if it's been 2 days since we last showed it)? And I assume the dismiss behavior overrides the 2 day restriction so we never show it again regardless of time period?

@pstakoun
Copy link
Contributor Author

@mike-plummer I would say no, only this one should have the "2 days" behavior, but I've been debating that a bit. You are correct in assuming the dismiss behavior overrides the 2 day restriction. Anything else unclear here?

@abelb
Copy link

abelb commented Aug 1, 2022

Figma Link

image

@baus
Copy link

baus commented Aug 1, 2022

@lmiller1990
Copy link
Contributor

lmiller1990 commented Aug 2, 2022

Looks like a few of the Dashboard Integration features have a "10 tests" requirement. If you pick this up, see if anyone else has implemented the "10 tests" check first, to avoid duplicate work 👍.

@marktnoonan
Copy link
Contributor

Is the A/B requirement dropped? The linked doc does not show the variants as far as I could tell.

It looks like we are about to starting saving a bunch more project-level state, which #22755 will help with by providing a "save project" state helper instead of a field-specific helper for each thing we need to save. This ticket would leverage that, for persisting dismissal, tracking last shown times, etc. Which might reduce the work's complexity.

But that ticket is in this same sprint, and I'd be cautious about interdependencies between separate tickets in the same sprint. We should keep that to a minimum, and all things being equal I think this is a good candidate to move to the next sprint.

@pstakoun
Copy link
Contributor Author

pstakoun commented Aug 2, 2022

@marktnoonan each prompt has A and B variants (one has a C as well) - this one has it for the CTA

@pstakoun
Copy link
Contributor Author

pstakoun commented Aug 2, 2022

This is high priority, so would push back against moving it out of the sprint and would rather move out others.

@marktnoonan
Copy link
Contributor

Ah cool @pstakoun I was reading the document incorrectly, ty. Let's review priority/order as a whole when everything is estimated.

@pstakoun
Copy link
Contributor Author

pstakoun commented Aug 2, 2022

I have removed the "2 days" limitation to simplify logic

@mike-plummer
Copy link
Contributor

mike-plummer commented Aug 8, 2022

@pstakoun To clarify this statement The current project is connected (i.e. has valid projectId): I assume the intent is to exclude situations where the user has a valid projectId but lacks access to the project?

Disregard, I forgot we have a warning banner for that states that would preclude this banner being displayed

@mike-plummer
Copy link
Contributor

Completed in #23256

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 30, 2022

Released in 10.7.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.7.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants