Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Modal: Pre-Select Existing Project #22936

Closed
pstakoun opened this issue Jul 26, 2022 · 9 comments · Fixed by #23266
Closed

Project Modal: Pre-Select Existing Project #22936

pstakoun opened this issue Jul 26, 2022 · 9 comments · Fixed by #23266
Assignees

Comments

@pstakoun
Copy link
Contributor

pstakoun commented Jul 26, 2022

In the "connect project" modal in the runs tab, pre-select the existing project if and only if there is only one.

@mike-plummer
Copy link
Contributor

@pstakoun Does the "no runs" check add value in this state? If there's only one project in the menu we may as well default the menu to that option regardless of its runs status

@pstakoun
Copy link
Contributor Author

@mike-plummer good point. I've been going back and forth on this one. Will think on it a bit...

@pstakoun
Copy link
Contributor Author

pstakoun commented Aug 1, 2022

@mike-plummer Updated with your suggestion - we will select the project if there is only one, regardless of whether or not it has runs.

@baus
Copy link

baus commented Aug 1, 2022

@rockindahizzy
Copy link
Contributor

@pstakoun, there is existing logic today that auto-selects a project if the local project name matches the cloud project name. I'm curious if this new auto-select logic should be in addition to or in place of the existing logic.

@pstakoun
Copy link
Contributor Author

@rockindahizzy nice catch, I didn't realize that. What I'm thinking is:

if there is a project that matches by name:
    pre-select the matching project
else if there is only one project:
    pre-select the first project

Does that make sense to you?

@rockindahizzy
Copy link
Contributor

@pstakoun, yep that makes perfect sense, thanks!

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 15, 2022

The code for this is done in cypress-io/cypress#23266, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot removed the stage: needs review The PR code is done & tested, needs review label Aug 15, 2022
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 15, 2022

Released in 10.5.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.5.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants