Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltips can cover the "New Spec" button #23115

Closed
marktnoonan opened this issue Aug 4, 2022 · 4 comments · Fixed by #23259
Closed

Tooltips can cover the "New Spec" button #23115

marktnoonan opened this issue Aug 4, 2022 · 4 comments · Fixed by #23259
Assignees
Labels
CT Issue related to component testing type: bug

Comments

@marktnoonan
Copy link
Contributor

Current behavior

Currently there's a mildly annoying situation where users intending to click "New Spec" on the Spec Lists have to be mindful of avoiding the Column heading beneath it with their pointer so that the tooltip doesn't cover the button.

tooltip.blocking.New.Spec.button.mov

Desired behavior

A small delay before tooltips open would avoid this. I'd suggest we increase the show delay above 0 in the main Tooltip Vue component so that simply passing over and element doesn't unintentionally trigger tooltips. A very unscientific test just now suggests 150 ms is a good starting point, and this is a good signal generally that the pointer has come to rest on an element, so it avoids a lot of scenarios where currently moving the mouse around can open many tooltips at once.

Test code to reproduce

N/A

Cypress Version

10.4.0

Other

No response

@pstakoun
Copy link
Contributor

pstakoun commented Aug 4, 2022

Good idea, I'd be ok with a small delay (100-150ms seems reasonable)

@mjhenkes mjhenkes added type: bug CT Issue related to component testing labels Aug 4, 2022
@ryanjwilke
Copy link
Contributor

Agreed. A delay would be great. Even something up to 200-300ms may be appropriate. I trust you judgement though. Whatever you think feels right really.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 11, 2022

The code for this is done in cypress-io/cypress#23259, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 15, 2022

Released in 10.5.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.5.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CT Issue related to component testing type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants