-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cookie behavior issue after 10.3.0 #23132
Comments
@lehmat are you sure that this happens on |
Wonder if the latest cross-origin cookie changes in the
PR #22963 by @mschile , approved by @mjhenkes @AtofStryker @chrisbreiding @emilyrohrbough To be clear our code / tests with |
Hi @lehmat. Thank you for opening an issue. Was this behavior working in What I think would make more sense is what @karlhorky has said here. Would you be able to confirm a few things for me. Can you run your Cypress test with |
One thing that I can confirm already now is that in my case, the cookies are not being set (the Application tab in Chrome confirms that no cookie has been set). My environment:
Cypress |
Seems suspect. Let me know when you are able to run with the debug flags! |
I've updated the post above to be clear that the API ( My hypothesis earlier today while I was looking at it was that the updated cross-origin handling of cookies that Cypress added is now treating
|
Not sure if my response was unclear but this is what is being said in #23132 (comment). The debug logs should verify this issue via |
Below is what came back from running Cypress 10.4.0 with
|
Hi, We found this issue on first on 10.3.0 and it has not been fixed in the later releases. Below are logs from the DEBUG option requested.
Unfortunately no
|
@karlhorky @lehmat thank you both for providing those logs. I think we should have enough information to produce on our end, especially with @karlhorky 's logs containing the failed set cookie due to thinking the request is cross origin, when the cookie really should be set since it is same origin (using the request url and referrer here will be super helpful for us to write a good test) |
@AtofStryker glad to help! Any ETA yet on when someone will take a look at this? |
@karlhorky not yet, but our team is planning tomorrow and this is likely coming up. We have some cookie issues we need to fix with |
@AtofStryker I just find about this issue, then I downgrade to 10.2.0 and it works, my use case is pretty simple. |
We met today and have the issue in the current sprint (I'm working the ticket). My guess is the fix is in the release in the next few weeks? Will keep you all updated. For now, if |
@karlhorky @lehmat can both of you confirm if you have the |
|
Same with me, |
Hi, same problem here. OK with cypress 10.3.0/10.3.1 Environment: In 10.3.1, session show a cookie (tokenca) and a storage 10.3.1
10.4.0
|
@AtofStryker any news here? Would love to be able to upgrade Cypress again...! |
The code for this is done in cypress-io/cypress#23438, but has yet to be released. |
@karlhorky sorry for the late reply. I was able to merge in #23438 which should alleviate the issues you both were seeing and should be in the next release, which should likely be around Tuesday next week. If for some reason it does not fix your issue, we are doing quite a bit of cookie work for |
@AtofStryker ok no worries :) Do you have a |
@karlhorky unfortunately we do not have a prerelease available with these changes yet, but the release should be available as early as Tuesday. If you are really eager to try it out, you could clone |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
@karlhorky @lehmat @PhilFlash changes should be released in |
I've upgraded to I have another issue, but I believe it is unrelated: a |
yay! That's great to hear.
Now that's not so great to hear 😢 . 99% likely unrelated as most the cookie work was done in the proxy server. Are you able to open an issue about the behavior you are seeing with |
I'm thinking that maybe it's re-querying an alias, wonder if it's a regression / new behavior introduced by #23652. Edit: Maybe it's actually exposing a bug that was never shown before in our tests - one of our aliases is getting requeried on a page that didn't actually have the root element haha. So it looks like it may be our own error here. Sorry for the noise! |
No worries at all. If you run into any problems, don't hesitate to open a new issue! |
For me, all is ok with 10.8.0. Thanks |
10.8.0 works perfect for me too |
Current behavior
localhost cookies are not sent on separate ports. In example we have the following setup:
Frontend -> localhost:5000
API -> localhost:5002
OAUTH2 -> localhost:5005
The frontend does not send cookies to API after 10.3.0 (see flow in extra information).
Desired behavior
Frontend should be sending API cookies as normal
Test code to reproduce
N/A
Cypress Version
10.3.0
Other
The text was updated successfully, but these errors were encountered: