-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When config files are created during onboarding, keep them collapsed #23260
Comments
I agree that all fields could be collapsed by default (except for conflicts as you suggested) with the exception of config. Config should always be open because this is a one time operation and it’s important the user understand and see how their setup was translated into the lens of how that’s expressed through config. The goal here is to help orient, train, and teach the user what goes where to help them understand what’s available to them in order to further customize the config. For instance the e2e and component functions are how you write plugins that can’t be autogenerated by us - it’s code the user has to write. There’s no UI pattern for doing this and we can’t lead you automatically to the things you’re trying to accomplish. Therefore it’s important to introduce the surface area that they will use in the future. |
Although I'm not convinced the config accordion should be collapsed by default, I'm okay with collapsing it by default and we'll keep an eye out for confusion from users. |
Hey team! Please add your planning poker estimate with ZenHub @amehta265 @astone123 @lmiller1990 @marktnoonan @mike-plummer @rockindahizzy @warrensplayer @ZachJW34 |
Is there any case were we need changes/warnings except for I don't know of any cases where this would happen off the top of my head, so what is the deliverable here? I was going to suggest "open It's hard to estimate the work required for this ticket when there's not clear use case where the |
We definitely will need to determine more concrete use cases/AC in order to have an idea of the scope of work for this issue. |
We should not be adding any warnings, etc outside of existing patterns. The use case is simply to reduce the amount of information the user is shown on this "config success" screen, so showing them the files created rather than all of their contents as well. @lmiller1990 @rockindahizzy maybe I'm not understanding the scope here - are these cases where the change is not as simple as: collapse file contents by default if and only if it is in the success state (green with checkmark)? |
@pstakoun, that clears it up for me 👍 |
The code for this is done in cypress-io/cypress#23659, but has yet to be released. |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
During onboarding, when config files are created, keep them collapsed on the "Configuration Files" screens. If they have warnings (changes required, etc.), then start with them open.
The text was updated successfully, but these errors were encountered: