-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TSConfig seemingly not used when passed in via angular's build options (see #23161) #23673
Comments
Uh oh, regression - thanks for the reproduction. Knowing where it was introduced is really useful. Are you interested in making a PR? If not I'll look for someone to pick it up internally. |
Will make a pr for it - I wasn't 100% certain if I misunderstood and it was working as intended ™️. Edit: pr -> #23696 |
The code for this is done in cypress-io/cypress#23696, but has yet to be released. |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
* chore: release @cypress/angular-v1.1.0 [skip ci] * chore: release @cypress/schematic-v2.1.0 [skip ci] * chore: release @cypress/mount-utils-v2.1.0 [skip ci] * chore: release @cypress/react-v6.2.0 [skip ci] * chore: release @cypress/react18-v1.1.0 [skip ci] * chore: release @cypress/svelte-v1.0.0 [skip ci] * chore: release @cypress/vue-v4.2.0 [skip ci] * chore: release @cypress/vue2-v1.1.0 [skip ci] * chore: release @cypress/webpack-dev-server-v2.3.0 [skip ci] * fix(cypress-schematic): suffix template files so they are not ignored (#23645) * chore: release @cypress/schematic-v2.1.1 [skip ci] * fix: Use tsconfig from build if exists (closes #23673) (#23696) Falls back to tsconfig.json if one is not passed in * feat: add support for generating angular component * feat: skip default test generation * feat: generate ct tests only if component was generated * feat: add @cypress/schematic to schematicCollections * feat: add documentation * docs: document component generation * add test * fix generate from component with dir * fix CI * add variable to job defaults * remove v13 support Co-authored-by: Mike Plummer <mike-plummer@users.noreply.github.com> Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net> Co-authored-by: Zachary Williams <ZachJW34@gmail.com> Co-authored-by: Ronnie Laugen <ronnie@rlaugen.no> Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com> Co-authored-by: Jordan <jordan@jpdesigning.com> Co-authored-by: Mark Noonan <mark@cypress.io> Co-authored-by: astone123 <adams@cypress.io> Co-authored-by: Lachlan Miller <lachlan.miller.1990@outlook.com> Co-authored-by: Blue F <blue@cypress.io>
Current behavior
In #23161 we were allowed to pass in an Angular config object, which also includes a tsconfig-path. However, that tsconfig path seems to be fully ignored; if I pass in a random string, everything builds/tests as it should. I dug a bit through the code and looking at e.g
cypress/npm/webpack-dev-server/src/helpers/angularHandler.ts
Line 135 in a9d9711
Desired behavior
In my Angular / NX apps I have:
I would also like to have a tsconfig.cypress.json to ensure the correct paths etc are used without having to interfere with the rest of my tsconfig-setup.
Test code to reproduce
Cypress Version
10.7.0
Node version
v18.4.0 (also tried with 16.2.0)
Operating System
macOS 12.5
Debug Logs
No response
Other
No response
The text was updated successfully, but these errors were encountered: