Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACI post-project connection] Connect smart banners to new logic #23767

Closed
marktnoonan opened this issue Sep 9, 2022 · 3 comments · Fixed by #23762
Closed

[ACI post-project connection] Connect smart banners to new logic #23767

marktnoonan opened this issue Sep 9, 2022 · 3 comments · Fixed by #23762
Assignees

Comments

@marktnoonan
Copy link
Contributor

marktnoonan commented Sep 9, 2022

Drive the SpecsListBanners behavior fully with the logic created in #23765.

Acceptance Criteria

  1. Log In, Create Organization, and Connect Project variants should all open the Connect Dashboard Modal Flow, which should change state accordingly
  2. Record Run variant should have a minimum 1 day delay from when any other Smart Prompt Banner variant is shown
  3. Record Run variant should have a minimum 1 day delay from when the Connect Dashboard Modal Flow is shown
  4. Record Run variant should show when logged_in && organizations > 0 && project_connected && runs === 0 && specs_written_not_matching_examples > 0
  5. All Smart Prompt Banners should have a minimum 1 day delay from when the Auto-Open Docs Menu is shown (confirm, is likely already implemented)

References
Whimsical: https://whimsical.com/get-to-first-run-TgixRWciqE1chPGDCHk5b2
Figma: https://www.figma.com/file/V0lCq4uBplf9J3GZRiD02m/ACI-Fast-Follows?node-id=19661%3A172759
Clickup: https://app.clickup.com/t/18033298/PM-2556

@baus
Copy link
Collaborator

baus commented Sep 12, 2022

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 24, 2022

The code for this is done in cypress-io/cypress#23762, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 25, 2022

Released in 10.11.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.11.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Oct 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants