Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Launchpad - login doesn't work from "Choose a browser" page if browser isn't open yet #23779

Closed
marktnoonan opened this issue Sep 12, 2022 · 2 comments · Fixed by #23787
Closed

Launchpad - login doesn't work from "Choose a browser" page if browser isn't open yet #23779

marktnoonan opened this issue Sep 12, 2022 · 2 comments · Fixed by #23787
Assignees
@marktnoonan
Labels
type: bug

Comments

@marktnoonan
Copy link
Contributor

Current behavior

Logging via the launchpad hangs at the "Waiting for you to log in" stage due to a runtime error:

Screen Shot 2022-09-12 at 9 59 12 AM

Screen Shot 2022-09-12 at 9 59 33 AM

This is caused by us attempting to focus a browser that is "active" in the sense that is is selected in this screen, but is not actually open.

Desired behavior

Log in should work.

Test code to reproduce

NA

Cypress Version

10.7.0

Node version

na

Operating System

na

Debug Logs

No response

Other

No response
@marktnoonan marktnoonan self-assigned this Sep 12, 2022
@marktnoonan marktnoonan mentioned this issue Sep 12, 2022
Merged
4 tasks
@cypress-bot cypress-bot bot added stage: review stage: needs review The PR code is done & tested, needs review and removed stage: review stage: needs review The PR code is done & tested, needs review labels Sep 12, 2022
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 12, 2022

The code for this is done in cypress-io/cypress#23787, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 13, 2022

Released in 10.8.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.8.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Sep 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@marktnoonan marktnoonan

Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: login/utm param bug fixes and test coverage cypress-io/cypress
1 participant
@marktnoonan