Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firefox Tooltip - Only Show when ChromeWebSecurity=false #23846

Closed
emilyrohrbough opened this issue Sep 15, 2022 · 3 comments · Fixed by #25034
Closed

Firefox Tooltip - Only Show when ChromeWebSecurity=false #23846

emilyrohrbough opened this issue Sep 15, 2022 · 3 comments · Fixed by #25034
Labels
browser: firefox good first issue Good for newcomers type: bug

Comments

@emilyrohrbough
Copy link
Member

emilyrohrbough commented Sep 15, 2022 •
edited
Loading

Current behavior

Screen Shot 2022-09-15 at 12 54 59 PM

when I have chromeWebSecurity=true
Screen Shot 2022-12-08 at 2 09 09 PM

when I have chromeWebSecurity=false
Screen Shot 2022-12-08 at 2 11 37 PM

Desired behavior

Only present the firefox info icon when chromeWebSecurity = false

Test code to reproduce

Launch Cypress with Firefox on machine.

Cypress Version

10.8.0
@keremh
Copy link

keremh commented Sep 26, 2022

hi can i work on this issue?

@Aleff13
Copy link

Aleff13 commented Oct 27, 2022

@keremh did u work on it?

@Pashozator Pashozator mentioned this issue Dec 7, 2022
Merged
@cypress-bot cypress-bot bot added the stage: needs review The PR code is done & tested, needs review label Dec 7, 2022
@mike-plummer mike-plummer changed the title Firefox Tooltip - Only Show when ChromeWebSecurity=true Firefox Tooltip - Only Show when ChromeWebSecurity=false Dec 8, 2022
@ryanthemanuel ryanthemanuel added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Dec 12, 2022
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 13, 2022

Released in 12.1.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.1.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Dec 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
browser: firefox good first issue Good for newcomers type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: display firefox tooltip with error CHROME_WEB_SECURITY_NOT_SUPPO… Pashozator/cypress
5 participants
@nagash77 @ryanthemanuel @keremh @emilyrohrbough @Aleff13