Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CT Stacktraces: Duplicate reporting of uncaught errors #23920

Closed
mike-plummer opened this issue Sep 21, 2022 · 2 comments · Fixed by #23957
Closed

CT Stacktraces: Duplicate reporting of uncaught errors #23920

mike-plummer opened this issue Sep 21, 2022 · 2 comments · Fixed by #23957
Assignees
@lmiller1990

Comments

@mike-plummer
Copy link
Contributor

Component tests improperly report the same uncaught error multiple times - likely caused by differences in architecture between e2e and ct which allows multiple error listeners to process the uncaught error. Logic changes were made to some tests to account for this during CT Stacktrace work (see .should(mode === 'component' ? 'have.length.gte' : 'have.length', 1) line of verify-failures.ts)

To reproduce, create a component that throws an error from a click listener then invoke that listener via a component test.

Screen Shot 2022-09-20 at 8.59.59 AM.png
@mike-plummer mike-plummer mentioned this issue Sep 21, 2022
Merged
2 tasks
@lmiller1990 lmiller1990 mentioned this issue Sep 23, 2022
Merged
4 tasks
@lmiller1990 lmiller1990 self-assigned this Sep 23, 2022
@lmiller1990
Copy link
Contributor

fixed #23957

@lmiller1990 lmiller1990 mentioned this issue Sep 28, 2022
Open
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 11, 2022

Released in 10.10.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.10.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Oct 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lmiller1990 lmiller1990

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: do not double handle errors in component testing cypress-io/cypress
2 participants
@mike-plummer @lmiller1990