Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command log messages are no longer being truncated to 50 lines #23995

Closed
gofr opened this issue Sep 27, 2022 · 4 comments · Fixed by #24089
Closed

Command log messages are no longer being truncated to 50 lines #23995

gofr opened this issue Sep 27, 2022 · 4 comments · Fixed by #24089
Labels

Comments

@gofr
Copy link

gofr commented Sep 27, 2022

Current behavior

#5630 added some CSS to truncate log messages to at most 50 lines. It uses the -webkit-line-clamp CSS property to achieve that. But as described in https://caniuse.com/css-line-clamp, this feature also needs display: -webkit-box on the element to work.

That display property was removed in #20465. Log messages are no longer being truncated.

The property needs to be added back here:

Desired behavior

Truncate long log messages.

Test code to reproduce

N/A

Cypress Version

10.2.0, but I can still see the same code on the develop branch

Node version

not relevant

Operating System

not relevant

Debug Logs

No response

Other

No response

@ZachJW34
Copy link
Contributor

Looks like a regression as I don't see any comment explaining why it was removed. I took a quick video to show the behavior:

Screen.Recording.2022-09-27.at.12.21.19.PM.mov

@gofr would you be interested in submitting a PR fixing this?

@ZachJW34 ZachJW34 self-assigned this Sep 27, 2022
@cypress-bot cypress-bot bot added the stage: awaiting response Potential fix was proposed; awaiting response label Sep 28, 2022
@nagash77 nagash77 assigned astone123 and unassigned ZachJW34 Sep 29, 2022
@melkstam
Copy link
Contributor

I would like to work on this if no one else already does!

@astone123
Copy link
Contributor

@melkstam feel free to take this on!

@astone123 astone123 removed their assignment Sep 30, 2022
@astone123 astone123 removed the stage: awaiting response Potential fix was proposed; awaiting response label Sep 30, 2022
@cypress-bot cypress-bot bot added the stage: needs review The PR code is done & tested, needs review label Oct 3, 2022
@astone123
Copy link
Contributor

Released in 10.10.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.10.0, please open a new issue.

@cypress-io cypress-io locked as resolved and limited conversation to collaborators Oct 12, 2022
@astone123 astone123 removed the stage: needs review The PR code is done & tested, needs review label Oct 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants