Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only Save Session after Successful Validation #24208

Closed
nagash77 opened this issue Oct 11, 2022 · 2 comments · Fixed by #24565
Closed

Only Save Session after Successful Validation #24208

nagash77 opened this issue Oct 11, 2022 · 2 comments · Fixed by #24565
Assignees
@chrisbreiding
Milestone
experimentalSessi...

Comments

@nagash77
Copy link
Contributor

  1. Storing the session should happen post validation
@chrisbreiding chrisbreiding mentioned this issue Nov 7, 2022
Merged
2 tasks
@cypress-bot cypress-bot bot added the stage: needs review The PR code is done & tested, needs review label Nov 7, 2022
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 10, 2022

The code for this is done in cypress-io/cypress#24565, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot removed the stage: needs review The PR code is done & tested, needs review label Nov 10, 2022
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 15, 2022

Released in 11.1.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v11.1.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chrisbreiding chrisbreiding

Labels
None yet
Projects
None yet
Milestone
experimentalSessionAndOrigin GA
Development

Successfully merging a pull request may close this issue.

fix: Only save session if validation succeeds cypress-io/cypress
3 participants
@nagash77 @chrisbreiding @emilyrohrbough