Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cookie commands to take domain into account #24264

Closed
mjhenkes opened this issue Oct 14, 2022 · 2 comments · Fixed by #24471
Closed

Update cookie commands to take domain into account #24264

mjhenkes opened this issue Oct 14, 2022 · 2 comments · Fixed by #24471
Assignees
Labels
topic: cookies 🍪 topic: cy.origin Problems or enhancements related to cy.origin command topic: session Issues when using session command

Comments

@mjhenkes
Copy link
Member

mjhenkes commented Oct 14, 2022

With the addition of cy.origin and cy.session we should

  1. update cy.cookie apis to allow users to pass in the domain as an option
  2. update the cy.cookie apis default to use the AUT domain as default if available

Spike into what options we have when setting cookies and the AUT is undefined.

This should affect getCookies, getCookie, setCookies, clearCookie and clearCookies.

@mjhenkes mjhenkes self-assigned this Oct 14, 2022
@mjhenkes mjhenkes assigned chrisbreiding and unassigned mjhenkes Oct 17, 2022
@chrisbreiding chrisbreiding changed the title Update cy.cookie API Update cookie commands Oct 25, 2022
@chrisbreiding chrisbreiding changed the title Update cookie commands Update cookie commands to take domain into account Oct 25, 2022
@cypress-bot cypress-bot bot added the stage: needs review The PR code is done & tested, needs review label Oct 31, 2022
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Nov 4, 2022
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 4, 2022

The code for this is done in cypress-io/cypress#24471, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 10, 2022

Released in 11.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v11.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic: cookies 🍪 topic: cy.origin Problems or enhancements related to cy.origin command topic: session Issues when using session command
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants