Skip to content

Removal of erraneous functionality in CT #24328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rockindahizzy opened this issue Oct 20, 2022 · 6 comments · Fixed by #24419
Closed

Removal of erraneous functionality in CT #24328

rockindahizzy opened this issue Oct 20, 2022 · 6 comments · Fixed by #24419
Assignees
Labels
CT Issue related to component testing

Comments

@rockindahizzy
Copy link
Contributor

rockindahizzy commented Oct 20, 2022

We want to remove functionality that was deemed as erraneous with regards to critical functionality in Component Testing. Use the no-dead-code paradigm when practical to ensure users don't experience unnecessary blockers.

Things that need to be removed

Global

  • deprecate style injections (including impl in mount-utils).

React

  • mountHook function
  • unmount function should no longer be exported
  • Auto aliasing of mounted component

Vue

  • Remove mount callback
@rockindahizzy rockindahizzy added type: breaking change Requires a new major release version CT Issue related to component testing ct-core and removed type: breaking change Requires a new major release version labels Oct 20, 2022
@baus
Copy link

baus commented Oct 24, 2022

@ZachJW34
Copy link
Contributor

I feel like this has been answered but wanted an explicit answer to this: For functionality that is being removed, do we deprecate, deprecate + throw error when used or deprecate + noop/log when used?

@rockindahizzy
Copy link
Contributor Author

rockindahizzy commented Oct 25, 2022

I feel like this has been answered but wanted an explicit answer to this: For functionality that is being removed, do we deprecate, deprecate + throw error when used or deprecate + noop/log when used?

@ZachJW34, my vote is to deprecate + throw.

@marktnoonan, could you give us the preferred method?

@astone123 astone123 self-assigned this Oct 26, 2022
@astone123 astone123 linked a pull request Oct 27, 2022 that will close this issue
2 tasks
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: review labels Oct 28, 2022
@lmiller1990
Copy link
Contributor

It looks like we didn't share the final conclusion to the question in the post above by @rockindahizzy.

We will deprecate styles,stylesheets, mountCallback and unmount. Those will throw errors in Cypress 11. The error will explain the deprecation, and link to the migration guide.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 4, 2022

The code for this is done in cypress-io/cypress#24419, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot removed the stage: needs review The PR code is done & tested, needs review label Nov 4, 2022
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 10, 2022

Released in 11.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v11.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CT Issue related to component testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants