CT mount types relying on @cypress/ don't work

[ZachJW34]

Current behavior

cypress/react18 has types defined in node_modules/cypress/react18/dist/index.d.ts that look like:

/// <reference types="cypress" />
/// <reference types="cypress" />
import React from 'react';
import type { MountOptions, UnmountArgs } from '@cypress/react'; // NOT GOOD
export declare function mount(jsx: React.ReactNode, options?: MountOptions, rerenderKey?: string): Cypress.Chainable<import("@cypress/react").MountReturn>;
export declare function unmount(options?: UnmountArgs): Cypress.Chainable<undefined>;

Notice the @cypress/react import (@ prefix). The types won't be found unless the user happens to have installed the mount package from npm which is unlikely. The lack of the types leads to any typing of the options.

Desired behavior

The types for cypress/react18 (using mount from cypress npm module) should be equivalent to the types for @cypress/react18. This problem also exists for our other mount packages as they have a reliance on @cypress/mount-utils, so they should be cleaned up as well. In summary, the types should work regardless of where the mount is coming from.

Test code to reproduce

Create a react18 project outside of our repo with npm init vite. Choose TS and create a test.

Cypress Version

10.10.0

Node version

v16.17.1

Operating System

macOS 12.4

Debug Logs

No response

Other

No response

[baus]

Hey team! Please add your planning poker estimate with Zenhub @amehta265 @astone123 @lmiller1990 @marktnoonan @mike-plummer @rockindahizzy @warrensplayer @ZachJW34

[ZachJW34]

For cypress/react18 I would expect the types to be copied over to the disted output, similar to how the source code is copied. If it were copied, this would ensure that both cypress/react18 and @cypress/react18 have equivalent types. Unless @cypress/react is listed as a dependency, the published package won't have proper types.

[cypress-bot]

The code for this is done in cypress-io/cypress#24415, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

[cypress-bot]

Released in 11.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v11.0.0, please open a new issue.