Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default cookie APIs domain to hostname instead of superdomain #24526

Closed
AtofStryker opened this issue Nov 3, 2022 · 2 comments
Closed

Default cookie APIs domain to hostname instead of superdomain #24526

AtofStryker opened this issue Nov 3, 2022 · 2 comments
Assignees
@chrisbreiding
Labels
v12.0.0 🐛
Milestone
experimentalSessi...

Comments

@AtofStryker
Copy link
Contributor

What would you like?

setCookie(s), getCookie(s), and clearCookie(s) should default to AUT hostname instead of AUT superdomain.

Why is this needed?

To keep consistency with the cookie spec and not force users to specify the exact domain of the AUT

Other

No response
@AtofStryker AtofStryker mentioned this issue Nov 3, 2022
Merged
4 tasks
@chrisbreiding chrisbreiding self-assigned this Nov 7, 2022
@chrisbreiding chrisbreiding mentioned this issue Nov 15, 2022
Merged
4 tasks
@cypress-bot cypress-bot bot added the stage: needs review The PR code is done & tested, needs review label Nov 15, 2022
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Nov 23, 2022
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 23, 2022

The code for this is done in cypress-io/cypress#24692, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 6, 2022

Released in 12.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Dec 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chrisbreiding chrisbreiding

Labels
v12.0.0 🐛
Projects
None yet
Milestone
experimentalSessionAndOrigin GA
Development

No branches or pull requests
2 participants
@chrisbreiding @AtofStryker