-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support lowercase environment variables to make npm config
working.
#24556
Labels
Comments
abcfy2
added a commit
to abcfy2/cypress
that referenced
this issue
Nov 13, 2022
`npm config set VAR VAL` will inject `npm_config_var=val` environment variable. This commit will solve this issue Closes: cypress-io#24556
abcfy2
added a commit
to abcfy2/cypress
that referenced
this issue
Nov 17, 2022
`npm config set VAR VAL` will inject `npm_config_var=val` environment variable. This commit will solve this issue Closes: cypress-io#24556
abcfy2
added a commit
to abcfy2/cypress
that referenced
this issue
Nov 17, 2022
`npm config set VAR VAL` will inject `npm_config_var=val` environment variable. This commit will solve this issue Closes: cypress-io#24556
abcfy2
added a commit
to abcfy2/cypress
that referenced
this issue
Nov 22, 2022
`npm config set VAR VAL` will inject `npm_config_var=val` environment variable. This commit will solve this issue Closes: cypress-io#24556
abcfy2
added a commit
to abcfy2/cypress
that referenced
this issue
Nov 23, 2022
`npm config set VAR VAL` will inject `npm_config_var=val` environment variable. This commit will solve this issue Closes: cypress-io#24556
abcfy2
added a commit
to abcfy2/cypress
that referenced
this issue
Nov 24, 2022
`npm config set VAR VAL` will inject `npm_config_var=val` environment variable. This commit will solve this issue Closes: cypress-io#24556
abcfy2
added a commit
to abcfy2/cypress
that referenced
this issue
Nov 27, 2022
`npm config set VAR VAL` will inject `npm_config_var=val` environment variable. This commit will solve this issue Closes: cypress-io#24556
mjhenkes
added a commit
that referenced
this issue
Dec 1, 2022
* fix: get correct env from npm config `npm config set VAR VAL` will inject `npm_config_var=val` environment variable. This commit will solve this issue Closes: #24556 * Disable commercial recommendations for system tests. * Disable commercial recommendations * Update system-tests/lib/system-tests.ts * Revert changes * Update cli/test/lib/util_spec.js * Update cli/test/lib/util_spec.js Co-authored-by: Matt Henkes <mjhenkes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Current behavior
npm config set CYPRESS_DOWNLOAD_PATH_TEMPLATE 'https://cdn.npmmirror.com/binaries/cypress/${version}/${platform}-${arch}/cypress.zip'
not working in current behavior.You can see download is still
https://download.cypress.io/desktop/10.11.0?platform=linux&arch=x64
Desired behavior
npm config set
will inject lowercase environment variables.E.g:
npm config set CYPRESS_DOWNLOAD_PATH_TEMPLATE 'https://cdn.npmmirror.com/binaries/cypress/${version}/${platform}-${arch}/cypress.zip'
will inject:So I think
cypress/cli/lib/util.js
Lines 532 to 564 in d52e610
Should also support lowercase environment variables.
Test code to reproduce
Cypress Version
10.11.0
Node version
18
Operating System
Linux
Debug Logs
The text was updated successfully, but these errors were encountered: