Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make inline spec list more a11y with Run All Specs experiment #24762

Closed
lmiller1990 opened this issue Nov 21, 2022 · 2 comments · Fixed by #24932
Closed

Make inline spec list more a11y with Run All Specs experiment #24762

lmiller1990 opened this issue Nov 21, 2022 · 2 comments · Fixed by #24932
Assignees
@marktnoonan
Labels
experimental: run all specs

Comments

@lmiller1990
Copy link
Contributor

lmiller1990 commented Nov 21, 2022 •
edited
Loading

What would you like?

When using Run All Specs, on the right hand side of the directories in the inline spec list, we should a "Play" button. Right now, you ca tab there, but hitting enter doesn't do anything. It's not a11y.

image

You should be able to tab there and hit enter to Run All Specs in that directory.

Why is this needed?

No response

Other

No response
@lmiller1990 lmiller1990 mentioned this issue Nov 21, 2022
Merged
@marktnoonan marktnoonan self-assigned this Dec 1, 2022
@marktnoonan marktnoonan mentioned this issue Dec 1, 2022
Merged
2 tasks
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 5, 2022

The code for this is done in cypress-io/cypress#24932, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 6, 2022

Released in 12.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Dec 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@marktnoonan marktnoonan

Labels
experimental: run all specs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: improve keyboard behavior of the inline specs list "run all" buttons cypress-io/cypress
2 participants
@marktnoonan @lmiller1990