-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detached DOM issues in Firefox headless not headed #24900
Comments
I signed up for a free account on Vidyard, but wasn't able to get the test running - there's no element If you want to email me the demo username and password at blue@cypress.io, I'll keep taking a look - you're right that the test looks correct at a glance, and the error certainly doesn't fit with the situation, so I'm curious to dig in and figure out what's going wrong. |
Or if you'd prefer not to share the login info, a simple set of steps to get the Thanks for the report though, definitely want to poke into it and see what's happening. |
Hi Blue, Thanks for reaching out! I sent you an email with the credentials. |
Super interesting, figured out what's going on and opened a PR for it. Should have it fixed before Cy12 ships. Thanks for the great bug report with repro. 👍 This started happening in the 12.0.0 binary because Cypress is now a lot more reliable and strict about visibility checks; the overflow element was always being hidden in headless firefox, but Cy11 didn't notice that fact to block the click. We've discovered a lot of edge cases like this, where the new, stricter checks are uncovering weird things Cypress was doing under the hood. |
Blue, you are amazing! Thanks for looking into this! Looking forward to the fix :) |
We didn't end up getting this into 12.0.0. I'm still following up, and will see about the next patch release. |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Current behavior
In Cypress versions 10-12, Firefox appears to execute differently between headed and headless versions. Using Firefox 107, all Cypress tests pass in open mode but fail with an assertion error:
"AssertionError: Timed out retrying after 4000ms: Expected to find element:
[data-testid=video-overflow-share], but never found it."
in run mode.Desired behavior
In this situation, where all environmental factors are the same, I would expect the headless version to mirror the headed version and pass all the tests that pass in headed mode.
Test code to reproduce
Here is a link to my repo where you can reproduce the error. The failing test is in the file: testing-dom__page-reloads/Client-Repro/cypress/e2e/1-getting-started/vidyard.cy.js.
Upon request, I can give the email and password that I used to sign in to vidyard.com.
Cypress Version
Cypress 12 from binary
Node version
v18.12.0
Operating System
macOS Ventura 13.0.1
Debug Logs
Other
No response
The text was updated successfully, but these errors were encountered: