Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expected e2e.testIsolation to be one of these values: true #25007

Closed
skjnldsv opened this issue Dec 6, 2022 · 4 comments · Fixed by #25008
Closed

Expected e2e.testIsolation to be one of these values: true #25007

skjnldsv opened this issue Dec 6, 2022 · 4 comments · Fixed by #25008

Comments

@skjnldsv
Copy link

skjnldsv commented Dec 6, 2022

Current behavior

When running a component test suite, cypress throws for the e2e config key testIsolation.
Running the e2e suite works fine

Desired behavior

Not throw for a valid e2e config

Test code to reproduce

nextcloud-libraries/nextcloud-cypress#111

// truncated imports

export default defineConfig({
	projectId: '123465',

	// Needed to trigger `after:run` events with cypress open
	experimentalInteractiveRunEvents: true,

	// faster video processing
	videoCompression: false,

	e2e: {
		// Disable session isolation
		testIsolation: false,

		setupNodeEvents(on, config) {
			// Remove container after run
			on('after:run', () => {
				stopNextcloud()
			})

			// Before the browser launches
			// starting Nextcloud testing container
			return startNextcloud(process.env.BRANCH)
				.then((ip) => {
					// Setting container's IP as base Url
					config.baseUrl = `http://${ip}/index.php`
					return ip
				})
				.then(waitOnNextcloud)
				.then(configureNextcloud)
				.then(() => {
					return config
				})
		},
	},

	component: {
		devServer: {
			framework: 'vue',
			bundler: 'webpack',
			webpackConfig,
		},
	},
})

Cypress Version

12.0.0

Node version

16.18.1

Operating System

Archlinux

Debug Logs

An invalid configuration value was set.

Expected e2e.testIsolation to be one of these values: true.

Instead the value was: false


### Other

_No response_
@skjnldsv skjnldsv changed the title Expected e2e.testIsolation to be one of these values: true. Expected e2e.testIsolation to be one of these values: true. Dec 6, 2022
@skjnldsv skjnldsv changed the title Expected e2e.testIsolation to be one of these values: true. Expected e2e.testIsolation to be one of these values: true Dec 6, 2022
@cypress-bot cypress-bot bot added the stage: needs review The PR code is done & tested, needs review label Dec 6, 2022
@emilyrohrbough
Copy link
Member

@skjnldsv Thank you for reporting this issue. Sorry this was causing you problems! I have put out a fix.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 6, 2022

The code for this is done in cypress-io/cypress#25008, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot removed the stage: needs review The PR code is done & tested, needs review label Dec 6, 2022
@mjhenkes
Copy link
Contributor

mjhenkes commented Dec 7, 2022

This was release in v12.0.1

@skjnldsv
Copy link
Author

skjnldsv commented Dec 7, 2022

@skjnldsv Thank you for reporting this issue. Sorry this was causing you problems! I have put out a fix.

No worries at all! :)
Thanks fr fixing it so fast!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants