Skip to content

White border on nav at certain zoom levels in Chrome #25284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marktnoonan opened this issue Dec 27, 2022 · 2 comments · Fixed by #25285
Closed

White border on nav at certain zoom levels in Chrome #25284

marktnoonan opened this issue Dec 27, 2022 · 2 comments · Fixed by #25285
Labels
CT Issue related to component testing

Comments

@marktnoonan
Copy link
Contributor

Current behavior

In Chrome at 125% and 175% zoom a distracting white border appears on the left nav when on the Test Runner page:

incorrect border

This is caused by an apparent bug in Chrome as it happens in no other browser. At these zoom levels, Chrome seems to make too much space for the 1px border.

Desired behavior

The border should be the usual dark gray at all zoom levels.

Test code to reproduce

Just change zoom levels with Cmd + +/- on the spec runner page (where it is noticeable).

The issue seems to be related to the use of grid-template-columns: auto and can be "fixed" by hardcoding a value greater than the true nav sidebar value for that part of the grid. It can also be fixed by moving the border to the right of the nav bar instead, which has the same visual appearance but doesn't show the bug.

Cypress Version

10.0.0-12.2.0

Node version

na

Operating System

macOs

Debug Logs

No response

Other

No response

@cypress-bot cypress-bot bot added the stage: needs review The PR code is done & tested, needs review label Dec 27, 2022
@emilyrohrbough emilyrohrbough added CT Issue related to component testing routed-to-ct labels Dec 28, 2022
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Dec 28, 2022
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 28, 2022

The code for this is done in cypress-io/cypress#25285, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jan 3, 2023

Released in 12.3.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.3.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jan 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CT Issue related to component testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants