Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug M1.1 - Update sidebar badge count display #25662

Closed
warrensplayer opened this issue Feb 1, 2023 · 4 comments · Fixed by #25737
Closed

Debug M1.1 - Update sidebar badge count display #25662

warrensplayer opened this issue Feb 1, 2023 · 4 comments · Fixed by #25737
Assignees

Comments

@warrensplayer
Copy link
Contributor

Current behavior
The Debug page badge in the sidebar will show the failed test count up to 9 and then shows "9+" when the count is above 9.

Desired behavior
The Debug page badge in the sidebar will show up to 99 and then show "99+" if the count is higher than 99.

  • Show the actual count up to 99
  • When above 99, show "99+"
  • Offset the badge in the collapsed mode so that it has consistent right margin from the edge of the sidebar (see Figma).

Figma: https://www.figma.com/file/PAOozuCxtfetqP8fUVvg0y/branch/QkCp2F69X0qyLo7qnYQ67e/Cypress-App?node-id=23899%3A229781&t=AeAPEJnkNCEES56e-1

@warrensplayer
Copy link
Contributor Author

@lmiller1990
Copy link
Contributor

lmiller1990 commented Feb 1, 2023

This part. Width of sidebar should not change.

image

@mike-plummer mike-plummer self-assigned this Feb 6, 2023
@mike-plummer
Copy link
Contributor

This is intended to only change badge behavior for failed count badge when sidebar is collapsed - other badge types ("New" and "0") should not change: https://cypressio.slack.com/archives/C042Y29PWCD/p1675782997330079

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 15, 2023

Released in 12.6.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.6.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants