Skip to content

Remove hover CTAs on Specs List for Cloud columns #25926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
warrensplayer opened this issue Feb 22, 2023 · 3 comments · Fixed by #26001
Closed

Remove hover CTAs on Specs List for Cloud columns #25926

warrensplayer opened this issue Feb 22, 2023 · 3 comments · Fixed by #26001
Assignees
@jordanpowell88
Labels
CT Issue related to component testing

Comments

@warrensplayer
Copy link
Contributor

warrensplayer commented Feb 22, 2023 •
edited by lmiller1990
Loading

Current behavior

When not connected to the cloud, the Specs list page will show links when hovering over the empty states in the "Latest Runs" and the "Average Duration" columns (the button that says "connect").

Screenshot 2023-02-22 at 4.59.02 PM.pngScreenshot 2023-02-22 at 4.58.45 PM.png

Desired behavior

These CTA links have not been converting, so they should be removed. Hovering over the empty states of the "Latest Runs" and the "Average Duration" columns when not connected to the cloud should no longer show the links.

Note: Clean up any unused components after removing these from the Specs list .
@warrensplayer warrensplayer added the CT Issue related to component testing label Feb 22, 2023
@warrensplayer
Copy link
Contributor Author

Hey team! Please add your planning poker estimate with Zenhub @astone123 @lmiller1990 @marktnoonan @mike-plummer @ZachJW34

@lmiller1990 lmiller1990 mentioned this issue Feb 23, 2023
Closed
@lmiller1990
Copy link
Contributor

Could combo w/ #25925 (one PR, get it all done in one shot).

@jordanpowell88 jordanpowell88 mentioned this issue Mar 2, 2023
Merged
3 tasks
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 14, 2023

Released in 12.8.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.8.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Mar 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jordanpowell88 jordanpowell88

Labels
CT Issue related to component testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove cloud connect button from app cypress-io/cypress
3 participants
@warrensplayer @jordanpowell88 @lmiller1990