Angular 16 not detected by CT

Current behavior

After Angular 16 has been installed, the Cypress desktop app in Component Testing mode does not detect the installation and shows the message "Waiting for you to install the dependencies".

Desired behavior

Angular 16 should be detected in Component Testing. The Cypress 12.11.0 changelog specifically mentions this as:

Added Component Testing support for Angular 16. Addresses Add Component Testing Support for Angular 16 #26044.

Test code to reproduce

mkdir cy-angular-ct
cd cy-angular-ct
git init
npm init -y
npm install cypress@12.13.0 -D -E
npx cypress open

Click on "Component Testing"
Select Front-end framework Angular
Click "Next step"
Copy and paste the command as instructed:
npm install -D @angular/cli @angular-devkit/build-angular @angular/core @angular/common @angular/platform-browser-dynamic
Note: The spinner and the text "Waiting for you to install the dependencies" remain displayed

Cypress Version

12.13.0

Node version

18.16.0

Operating System

Ubuntu 22.04

Debug Logs

No response

Other

It looks like a similar root cause to fix: Correct typescript scaffold dependency #26815 concerning putting the version in single quotes.

It looks like each line

minVersion: '^=13.0.0 || ^=14.0.0 || ^=15.0.0' || '^=16.0.0',

should be

minVersion: '^=13.0.0 || ^=14.0.0 || ^=15.0.0 || ^=16.0.0',

cypress/packages/scaffold-config/src/dependencies.ts

Lines 100 to 143 in d91177a

    
           export const WIZARD_DEPENDENCY_ANGULAR_CLI = { 
        
             type: 'angular', 
        
             name: 'Angular CLI', 
        
             package: '@angular/cli', 
        
             installer: '@angular/cli', 
        
             description: 'CLI tool that you use to initialize, develop, scaffold, and maintain Angular applications.', 
        
             minVersion: '^=13.0.0 || ^=14.0.0 || ^=15.0.0' || '^=16.0.0', 
        
           } as const 
        
           export const WIZARD_DEPENDENCY_ANGULAR_DEVKIT_BUILD_ANGULAR = { 
        
             type: 'angular', 
        
             name: 'Angular DevKit Build Angular', 
        
             package: '@angular-devkit/build-angular', 
        
             installer: '@angular-devkit/build-angular', 
        
             description: 'Angular Webpack build facade', 
        
             minVersion: '^=13.0.0 || ^=14.0.0 || ^=15.0.0' || '^=16.0.0', 
        
           } as const 
        
           export const WIZARD_DEPENDENCY_ANGULAR_CORE = { 
        
             type: 'angular', 
        
             name: 'Angular Core', 
        
             package: '@angular/core', 
        
             installer: '@angular/core', 
        
             description: 'The core of the Angular framework', 
        
             minVersion: '^=13.0.0 || ^=14.0.0 || ^=15.0.0' || '^=16.0.0', 
        
           } as const 
        
           export const WIZARD_DEPENDENCY_ANGULAR_COMMON = { 
        
             type: 'angular', 
        
             name: 'Angular Common', 
        
             package: '@angular/common', 
        
             installer: '@angular/common', 
        
             description: 'Commonly needed Angular directives and services', 
        
             minVersion: '^=13.0.0 || ^=14.0.0 || ^=15.0.0' || '^=16.0.0', 
        
           } as const 
        
           export const WIZARD_DEPENDENCY_ANGULAR_PLATFORM_BROWSER_DYNAMIC = { 
        
             type: 'angular', 
        
             name: 'Angular Platform Browser Dynamic', 
        
             package: '@angular/platform-browser-dynamic', 
        
             installer: '@angular/platform-browser-dynamic', 
        
             description: 'Library for using Angular in a web browser with JIT compilation', 
        
             minVersion: '^=13.0.0 || ^=14.0.0 || ^=15.0.0' || '^=16.0.0', 
        
           } as const

@jordanpowell88

@jordanpowell88

Do you want a PR for this issue? I have a fix branch prepared if you would like it.
Would it be too late for Cypress 12.13.1 or is there still time?

@MikeMcC399

@MikeMcC399 here is my PR that should get this released next week #26908

@jordanpowell88

@jordanpowell88

here is my PR that should get this released next week #26908

I somehow missed your new PR. It's very good you have one prepared anyway!

I was really just practising because although I have submitted a lot of other PRs into the Cypress eco-system I had never done one for the core Cypress product, so at least I have now done a dry run of preparation and testing ready for some other future PR! I'll delete my branch now as it is more or less a duplicate of yours (except I added to 12.13.1 and yours is for 12.14.0 in the changelog).

Well you are a legend inside of Cypress and we appreciate all your work. We are never short of things to be do so I'm sure we can get a PR merged soon enough

Released in 12.14.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.14.0, please open a new issue.

Navigation Menu

Repository navigation

Angular 16 not detected by CT #26852

Current behavior

Desired behavior

Test code to reproduce

Cypress Version

Node version

Operating System

Debug Logs

Other

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	export const WIZARD_DEPENDENCY_ANGULAR_CLI = {
	type: 'angular',
	name: 'Angular CLI',
	package: '@angular/cli',
	installer: '@angular/cli',
	description: 'CLI tool that you use to initialize, develop, scaffold, and maintain Angular applications.',
	minVersion: '^=13.0.0 \|\| ^=14.0.0 \|\| ^=15.0.0' \|\| '^=16.0.0',
	} as const

	export const WIZARD_DEPENDENCY_ANGULAR_DEVKIT_BUILD_ANGULAR = {
	type: 'angular',
	name: 'Angular DevKit Build Angular',
	package: '@angular-devkit/build-angular',
	installer: '@angular-devkit/build-angular',
	description: 'Angular Webpack build facade',
	minVersion: '^=13.0.0 \|\| ^=14.0.0 \|\| ^=15.0.0' \|\| '^=16.0.0',
	} as const

	export const WIZARD_DEPENDENCY_ANGULAR_CORE = {
	type: 'angular',
	name: 'Angular Core',
	package: '@angular/core',
	installer: '@angular/core',
	description: 'The core of the Angular framework',
	minVersion: '^=13.0.0 \|\| ^=14.0.0 \|\| ^=15.0.0' \|\| '^=16.0.0',
	} as const

	export const WIZARD_DEPENDENCY_ANGULAR_COMMON = {
	type: 'angular',
	name: 'Angular Common',
	package: '@angular/common',
	installer: '@angular/common',
	description: 'Commonly needed Angular directives and services',
	minVersion: '^=13.0.0 \|\| ^=14.0.0 \|\| ^=15.0.0' \|\| '^=16.0.0',
	} as const

	export const WIZARD_DEPENDENCY_ANGULAR_PLATFORM_BROWSER_DYNAMIC = {
	type: 'angular',
	name: 'Angular Platform Browser Dynamic',
	package: '@angular/platform-browser-dynamic',
	installer: '@angular/platform-browser-dynamic',
	description: 'Library for using Angular in a web browser with JIT compilation',
	minVersion: '^=13.0.0 \|\| ^=14.0.0 \|\| ^=15.0.0' \|\| '^=16.0.0',
	} as const

Angular 16 not detected by CT #26852

Description

Current behavior

Desired behavior

Test code to reproduce

Cypress Version

Node version

Operating System

Debug Logs

Other

Activity

MikeMcC399 commented on May 25, 2023

MikeMcC399 commented on Jun 2, 2023

jordanpowell88 commented on Jun 2, 2023

MikeMcC399 commented on Jun 2, 2023

jordanpowell88 commented on Jun 2, 2023

cypress-bot commented on Jun 7, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions