Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade commit-info dependency to >= v2.1.0 #2848

Closed
bahmutov opened this issue Nov 27, 2018 · 1 comment
Closed

Upgrade commit-info dependency to >= v2.1.0 #2848

bahmutov opened this issue Nov 27, 2018 · 1 comment

Comments

@bahmutov
Copy link
Contributor

@bahmutov bahmutov commented Nov 27, 2018

https://github.com/cypress-io/commit-info/releases/tag/v2.1.0 adds fallback environment variables. For setups where git is missing or .git folder is missing, this could be the "polyfill" to provide commit information via environment variables

@bahmutov bahmutov self-assigned this Nov 27, 2018
@bahmutov bahmutov changed the title Upgrade commit-info dependency to > v2.1.0 Upgrade commit-info dependency to >= v2.1.0 Nov 27, 2018
bahmutov added a commit that referenced this issue Dec 4, 2018
brian-mann added a commit that referenced this issue Dec 17, 2018
…to get Git commit (#2895)

* chore: upgrade commit-info to 2.1.1 in server, close #2848

* chore: using mocked-env to test CI params

* update more CI env tests

* update last CI tests to use mocked-env

* test git commit info from environment variables

* do not crash on undefined when running npm t

* remove duplicate object key to pass linter
@brian-mann
Copy link
Member

@brian-mann brian-mann commented Dec 26, 2018

Released in 3.1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants